Skip to content

Remove name opt from create/update opts#3017

Open
manji-0 wants to merge 1 commit intogophercloud:mainfrom
manji-0:remove_name_param_from_endpoint_createopts
Open

Remove name opt from create/update opts#3017
manji-0 wants to merge 1 commit intogophercloud:mainfrom
manji-0:remove_name_param_from_endpoint_createopts

Conversation

@manji-0
Copy link
Copy Markdown

@manji-0 manji-0 commented Mar 28, 2024 •
edited
Loading

Fixes #3016

Remove name opt from create/update opts because the property is not in endpoint schema (1).

Also, name is not in keystone api v3 document (2).

Links to the line numbers/files in the OpenStack source code that support the code in this PR:

github-actions[bot]
github-actions bot reviewed Mar 28, 2024
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.

@github-actions github-actions bot added the semver:major Breaking change label Mar 28, 2024
@stephenfin stephenfin force-pushed the remove_name_param_from_endpoint_createopts branch from 602f291 to 8a16433 Compare May 23, 2025 16:21
@kayrus
Copy link
Copy Markdown
Contributor

kayrus commented May 23, 2025

here is my recent devstack installation, the names are there:

$ curl -s http://localhost/identity/v3/services? -H "Accept: application/json" -H "User-Agent: python-keystoneclient" -H "X-Auth-Token: ${OS_AUTH_TOKEN}" | jq -r
{
  "services": [
    {
      "name": "keystone",
      "id": "29e85e4bd9344e83aac202db22229dec",
      "type": "identity",
      "enabled": true,
      "links": {
        "self": "http://10.180.142.80/identity/v3/services/29e85e4bd9344e83aac202db22229dec"
      }
    },
    {
      "description": "Designate DNS Service",
      "name": "designate",
      "id": "53cee1eb734947a2b32c44da31592278",
      "type": "dns",
      "enabled": true,
      "links": {
        "self": "http://10.180.142.80/identity/v3/services/53cee1eb734947a2b32c44da31592278"
      }
    }
  ],
  "links": {
    "next": null,
    "self": "http://10.180.142.80/identity/v3/services",
    "previous": null
  }
}

@github-actions github-actions bot added the edit:identity This PR updates identity code label May 23, 2025
@stephenfin
Copy link
Copy Markdown
Contributor

stephenfin commented May 23, 2025

here is my recent devstack installation, the names are there:

$ curl -s http://localhost/identity/v3/services? -H "Accept: application/json" -H "User-Agent: python-keystoneclient" -H "X-Auth-Token: ${OS_AUTH_TOKEN}" | jq -r
{
  "services": [
    {
      "name": "keystone",
      "id": "29e85e4bd9344e83aac202db22229dec",
      "type": "identity",
      "enabled": true,
      "links": {
        "self": "http://10.180.142.80/identity/v3/services/29e85e4bd9344e83aac202db22229dec"
      }
    },
    {
      "description": "Designate DNS Service",
      "name": "designate",
      "id": "53cee1eb734947a2b32c44da31592278",
      "type": "dns",
      "enabled": true,
      "links": {
        "self": "http://10.180.142.80/identity/v3/services/53cee1eb734947a2b32c44da31592278"
      }
    }
  ],
  "links": {
    "next": null,
    "self": "http://10.180.142.80/identity/v3/services",
    "previous": null
  }
}

Different API. You want http://localhost/identity/v3/endpoints.

>>> import openstack
>>> conn = openstack.connect()
>>> conn.identity.get('/endpoints').json()['endpoints'][0].keys()
dict_keys(['id', 'interface', 'region_id', 'service_id', 'url', 'enabled', 'region', 'links'])

stephenfin
stephenfin approved these changes May 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@stephenfin stephenfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI and @kayrus are happy.

@kayrus
Copy link
Copy Markdown
Contributor

kayrus commented May 23, 2025

Different API

hm, I executed openstack endpoint list

@stephenfin
Copy link
Copy Markdown
Contributor

stephenfin commented May 23, 2025

Different API

hm, I executed openstack endpoint list

Yeah, that's a meta command that takes the output of the services API and combined it with the output of the endpoint API. If you search higher in the debug output you'll likely see the call to the latter.

@mandre mandre mentioned this pull request Jan 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@stephenfin stephenfin stephenfin approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

edit:identity This PR updates identity code semver:major Breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove name property from endpoints.CreateOpts

3 participants

@manji-0 @kayrus @stephenfin