Skip to content

add: description field to identity.v3.Endpoint#3572

Merged
mandre merged 2 commits intogophercloud:mainfrom
winiciusallan:endpoint-description
Dec 11, 2025
Merged

add: description field to identity.v3.Endpoint#3572
mandre merged 2 commits intogophercloud:mainfrom
winiciusallan:endpoint-description

Conversation

@winiciusallan
Copy link
Copy Markdown
Contributor

The description field wasn't documented on the Endpoint API reference. See here for more information.

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://github.com/openstack/keystone/blob/master/keystone/catalog/schema.py#L286-L289

Signed-off-by: Winicius Silva <winiciusab12@gmail.com>
@github-actions github-actions bot added edit:identity This PR updates identity code semver:minor Backwards-compatible change backport-v2 This PR will be backported to v2 labels Dec 10, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 10, 2025

Coverage Status

coverage: 63.756% (-0.05%) from 63.807%
when pulling c707541 on winiciusallan:endpoint-description
into 31e1e30 on gophercloud:main.

Copy link
Copy Markdown
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we add acceptance tests for that. I see at the moment, the endpoint tests are very minimal as we're only testing the List function.

Signed-off-by: Winicius Silva <winiciusab12@gmail.com>
@winiciusallan
Copy link
Copy Markdown
Contributor Author

winiciusallan commented Dec 11, 2025

@mandre Sorry to force pushing many times, these was trying to fix failed CIs. Apparently, there is something when I try to run linter locally, maybe Makefile identation 😅 . I'll figure it out.

> make lint
Makefile:1: *** missing separator.  Stop.

It would be great if we add acceptance tests for that. I see at the moment, the endpoint tests are very minimal as we're only testing the List function.

I've added a TestEndpointCrud to check creation/deletion/update flow. I also added these methods to accept Description field. :)

@winiciusallan
Copy link
Copy Markdown
Contributor Author

Functional basis jobs are failing, it seems that actions can't download etcd package

++ functions:get_extra_file:68              :   wget --progress=dot:giga -t 2 -c https://github.com/etcd-io/etcd/releases/download/v3.4.27/etcd-v3.4.27-linux-amd64.tar.gz -O /home/runner/work/gophercloud/gophercloud/devstack/files/etcd-v3.4.27-linux-amd64.tar.gz
--2025-12-11 16:21:26--  https://github.com/etcd-io/etcd/releases/download/v3.4.27/etcd-v3.4.27-linux-amd64.tar.gz
Resolving github.com (github.com)... 140.82.112.4
Connecting to github.com (github.com)|140.82.112.4|:443... connected.
HTTP request sent, awaiting response... 503 Service Unavailable
2025-12-11 16:21:28 ERROR 503: Service Unavailable.

Copy link
Copy Markdown
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks a lot!

@mandre mandre enabled auto-merge December 11, 2025 17:02
@mandre mandre added this pull request to the merge queue Dec 11, 2025
Merged via the queue into gophercloud:main with commit b97ec1d Dec 11, 2025
65 of 68 checks passed
@winiciusallan winiciusallan deleted the endpoint-description branch December 16, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v2 This PR will be backported to v2 edit:identity This PR updates identity code semver:minor Backwards-compatible change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants