Identity: Add description field to roles #3532
Merged
stephenfin merged 1 commit intogophercloud:mainfrom Nov 3, 2025
Merged
Conversation
kayrus
reviewed
Oct 10, 2025
c367b14 to
07a8796
Compare
kayrus
requested changes
Oct 11, 2025
Contributor
kayrus
left a comment
There was a problem hiding this comment.
oh, unit tests are failing. please fix them.
07a8796 to
54afa88
Compare
stephenfin
requested changes
Oct 13, 2025
Contributor
stephenfin
left a comment
There was a problem hiding this comment.
It looks like we already have the ability to set description if we so choose, but I think we should be more explicit and define actual fields. I also think we should add the one other missing field for this API while we're here, but I'd understand if you wanted to leave that to a future PR.
0d3b68b to
86be91c
Compare
kayrus
previously approved these changes
Oct 15, 2025
Contributor
kayrus
left a comment
There was a problem hiding this comment.
since the description is officialy supported by API, its worth adding it.
mandre
reviewed
Oct 19, 2025
mandre
reviewed
Oct 19, 2025
605b660 to
9458599
Compare
mandre
previously approved these changes
Oct 22, 2025
stephenfin
previously approved these changes
Nov 3, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 3, 2025
Identity: Add description field to roles
Signed-off-by: Daniel Lawton <dlawton@redhat.com>
9458599 to
c16fa09
Compare
stephenfin
approved these changes
Nov 3, 2025
mandre
added a commit
to shiftstack/gophercloud
that referenced
this pull request
Dec 8, 2025
This is a follow-up to gophercloud#3532 that restores the backward compatibility with the old behavior, where `description` was returned in the `Extra` field. We will drop this for the next major release.
mandre
added a commit
to shiftstack/gophercloud
that referenced
this pull request
Dec 8, 2025
This is a follow-up to gophercloud#3532 that restores the backward compatibility with the old behavior, where `description` was returned in the `Extra` field. We will drop this for the next major release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.