Closed
Conversation
3cafa73 to
0ea71c0
Compare
0ea71c0 to
cb45b56
Compare
cb45b56 to
b2c7000
Compare
b2c7000 to
2142564
Compare
2142564 to
e222a80
Compare
Data as service type, microversion, service name, etc. are needed in ServiceClient struct because clients of services like Nova Compute or Manila need to insert an extra HTTP header which name depends on the service name and its value contains the service microversion. Data as service type, microversion, service name, etc. are not returned from the V2EndpointURL and V3EndpointURL functions even though they are available in these functions That's why the EndpointExtraInfo struct was added into the EndpointLocator type return values. The EndpointExtraInfo struct is not used yet, is kept empty and is being ignored.
e222a80 to
aa35f80
Compare
Merged
added 4 commits
June 5, 2017 14:12
…ceClient Data as service type, microversion, service name, etc. are needed in ServiceClient struct because clients of services like Nova Compute or Manila need to insert an extra HTTP header which name depends on the service name and its value contains the service microversion. Data as service type, microversion, service name, etc. are not returned from the V2EndpointURL and V3EndpointURL functions even though they are available in these functions. That's why the V2EndpointURL and V3EndpointURL functions also return the EndpointExtraInfo struct that contain service type, etc. Methods for working with the EndpointExtraInfo struct are implemented.
Shared file system API uses microversions. Some API calls like share instance export locations (https://developer.openstack.org/api-ref/shared-file-systems/?expanded=id234-detail#share-instance-export-locations-since-api-v2-9) are available from certain API microversion. That's why getting the API microversion is a prerequisite for implementation of such API calls. So GET call to obtain Shared File Systems microversion is added. In addition, newly created Shared File System ServiceClient has the microversion set.
Services like Nova and Manila require a client to fill HTTP header that contains the type of this service and microversion value because these services use microversions, i.e. certain requests are available from certain microversion. That's why a func for creating such API Microversion HTTP header was added and this header is filled in HTTP Get, Post, Put, etc. methods.
0867102 to
2cf0a75
Compare
Contributor
Author
|
Solution in #355 was chosen that's why this PR is closed without merge. |
msheikh-wind
pushed a commit
to msheikh-wind/gophercloud
that referenced
this pull request
May 19, 2025
* Reboot issue when insync is false - Added annotation restore in progress - insync, reconcile status and deployment scope are captured in annotation - Updated status in platform network contorller Test plan: - Install helm based DM with platform network in config file - Helm based DM should be running - Check all the crds, insync and reconciled should be true - Set garbage values to annoatation deployment-manager/restore-in- progress, reconcilation should not trigger - Verify Generation == ObservedGeneration Signed-off-by: mmanthir <mahalakshmi.manthiram@windriver.com> * Reboot issue when insync is false - Added annotation restore in progress - insync, reconcile status and deployment scope are captured in annotation - Updated status in platform network contorller Test plan: - Install helm based DM with platform network in config file - Helm based DM should be running - Check all the crds, insync and reconciled should be true - Set garbage values to annoatation deployment-manager/restore-in- progress, reconcilation should not trigger - Verify Generation == ObservedGeneration Signed-off-by: mmanthir <mahalakshmi.manthiram@windriver.com> * Restore DM Objects without Reconciliation During Upgrade - Added annotation RestoreInProgress - Implemented to restore dm objects without reconcilataion on platform network, ptp instance controller, ptp interface controller, data network, system and host controllers. Test plan: - Install helm based DM with platform network in config file - Helm based DM should be running - Check all the crds, insync and reconciled should be true - Set garbage values to annotation deployment-manager/restore-in- progress, reconcilation should not trigger - Verify Generation == ObservedGeneration - During restore whatever be the status/spec, no reconciliation is expected - After restore it should always attempt to reconcile ( Signed-off-by: mmanthir <mahalakshmi.manthiram@windriver.com> --------- Signed-off-by: mmanthir <mahalakshmi.manthiram@windriver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #53
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://github.com/openstack/manila/blob/master/manila/common/config.py#L194
https://github.com/openstack/manila/blob/master/manila/common/config.py#L203