Networking v2: Support two time formats for subnet, router, SG rule (#3492)#3493
Merged
mandre merged 1 commit intogophercloud:mainfrom Aug 13, 2025
Merged
Networking v2: Support two time formats for subnet, router, SG rule (#3492)#3493mandre merged 1 commit intogophercloud:mainfrom
mandre merged 1 commit intogophercloud:mainfrom
Conversation
mandre
reviewed
Aug 13, 2025
Contributor
mandre
left a comment
There was a problem hiding this comment.
Yes! Thanks for the patch, this is exactly how we should handle different possible formats returned by OpenStack. Just a minor nit about leftover debug in each of the added UnmarshalJSON() functions.
The linter is also failing due to improperly formatted code. This needs fixing before we can merge.
| return nil | ||
| } | ||
|
|
||
| // return errors.New("test error") |
Contributor
Author
There was a problem hiding this comment.
(should be all clean now)
mandre
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This is meant to resolve #3492)
For the Networking v2 API, Gophercloud has support for two time formats for the
created_at/updated_atfields, for most of the resources for which it supports such fields. This was introduced by #1671. Such support however is lacking for some resources (the resources for which the support for thecreated_at/updated_atfields was added later, in 99b0a51)This PR adds support for two time formats for the subnet, router, and SG rule resources.
It does it in the same way as in #1671, and adds the corresponding unit tests.