Add networking taas tapmirror suite#3483
Merged
stephenfin merged 3 commits intogophercloud:mainfrom Aug 11, 2025
Merged
Conversation
4 tasks
kayrus
reviewed
Aug 6, 2025
internal/acceptance/openstack/networking/v2/extensions/taas/tapmirrors_test.go
Show resolved
Hide resolved
428fb45 to
8fd72d2
Compare
Contributor
|
we can not enable this service in devstack. taap requires
|
8fd72d2 to
bc9ccfa
Compare
Contributor
|
@vydrazde have you tried to run functional tests in your environment? |
Contributor
Author
|
@kayrus I have run the acceptance tests, I wouldn't push them if they didn't pass. |
kayrus
reviewed
Aug 8, 2025
kayrus
previously approved these changes
Aug 8, 2025
Contributor
|
@EmilienM @stephenfin @pierreprinetti please review |
kayrus
approved these changes
Aug 8, 2025
stephenfin
approved these changes
Aug 11, 2025
Contributor
|
On the assumption that the new tests have been run locally. We likely want to add a new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3482
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://github.com/openstack/tap-as-a-service/blob/7984544610ed949414967cfe950f18336fa21880/neutron_taas/db/tap_mirror_db.py#L82
https://github.com/openstack/tap-as-a-service/blob/7acc6654ecdffafb22e6ef9ad64606e0c902a722/neutron_taas/services/taas/drivers/linux/ovs_taas.py#L584
I am not sure how to best deal with the Directions. According to docs and unit tests the values of the Directions should be integers. However, using the python taas client with python openstack client from bash sets the values as strings. From my testing the taas accepts both
intandstras long as thestrcan be converted tointand saves thestrunchanged (eq '002' is valid and returned as '002'). To not fail when listing or showing Tap Mirrors created by the python client I set the type asstr, but I am open to suggestions.