Change Direction value type to int

vydrazde · vydrazde · commit 2c6c60b38f28 · 2025-08-08T14:00:14.000+02:00
diff --git a/internal/acceptance/openstack/networking/v2/extensions/taas/taas.go b/internal/acceptance/openstack/networking/v2/extensions/taas/taas.go
@@ -2,7 +2,6 @@ package taas
 
 import (
 	"context"
-	"strconv"
 	"testing"
 
 	"github.com/gophercloud/gophercloud/v2"
@@ -26,8 +25,8 @@ func CreateTapMirror(t *testing.T, client *gophercloud.ServiceClient, portID str
 		MirrorType:  tapmirrors.MirrorTypeErspanv1,
 		RemoteIP:    remoteIP,
 		Directions: tapmirrors.Directions{
-			In:  strconv.Itoa(mirrorDirectionIN),
-			Out: strconv.Itoa(mirrorDirectionIN + 1),
+			In:  mirrorDirectionIN,
+			Out: mirrorDirectionIN + 1,
 		},
 	}
 
diff --git a/openstack/networking/v2/extensions/taas/tapmirrors/requests.go b/openstack/networking/v2/extensions/taas/tapmirrors/requests.go
@@ -44,9 +44,10 @@ type CreateOpts struct {
 	// The remote IP of the Tap Mirror, this will be the remote end of the GRE or ERSPAN v1 tunnel.
 	RemoteIP string `json:"remote_ip"`
 
-	// A dictionary of direction and tunnel_id. Directions are IN and OUT.
-	// The values of the directions must be unique within the project and
-	// must be convertible to int.
+	// A dictionary of direction and tunnel_id. Directions are In and Out. In specifies
+	// ingress traffic to the port will be mirrored, Out specifies egress traffic will be mirrored.
+	// The values of the directions are the identifiers of the ERSPAN or GRE session between
+	// the source and destination, these must be unique within the project.
 	Directions Directions `json:"directions"`
 }
 
diff --git a/openstack/networking/v2/extensions/taas/tapmirrors/results.go b/openstack/networking/v2/extensions/taas/tapmirrors/results.go
@@ -36,18 +36,18 @@ type TapMirror struct {
 	// A dictionary of direction and tunnel_id. Directions are In and Out. In specifies
 	// ingress traffic to the port will be mirrored, Out specifies egress traffic will be mirrored.
 	// The values of the directions are the identifiers of the ERSPAN or GRE session between
-	// the source and destination, these must be unique within the project and must be convertible to int.
+	// the source and destination, these must be unique within the project.
 	Directions Directions `json:"directions"`
 }
 
 type Directions struct {
-	// Unique identifier of the tunnel with ingress traffic. Must be convertible to int.
-	// Omit to not capture ingress traffic.
-	In string `json:"IN,omitempty"`
+	// Unique identifier of the tunnel with ingress traffic. Omit to not capture ingress traffic.
+	// Encoded as JSON string to be compatible with python tap-as-a-service client.
+	In int `json:"IN,omitempty,string"`
 
-	// Unique identifier of the tunnel with egress traffic. Must be convertible to int.
-	// Omit to not capture egress traffic.
-	Out string `json:"OUT,omitempty"`
+	// Unique identifier of the tunnel with egress traffic. Omit to not capture egress traffic.
+	// Encoded as JSON string to be compatible with python tap-as-a-service client.
+	Out int `json:"OUT,omitempty,string"`
 }
 
 type commonResult struct {
diff --git a/openstack/networking/v2/extensions/taas/tapmirrors/testing/requests_test.go b/openstack/networking/v2/extensions/taas/tapmirrors/testing/requests_test.go
@@ -68,8 +68,8 @@ func TestCreate(t *testing.T) {
 		MirrorType:  tapmirrors.MirrorTypeErspanv1,
 		RemoteIP:    "192.168.54.217",
 		Directions: tapmirrors.Directions{
-			In:  "1",
-			Out: "2",
+			In:  1,
+			Out: 2,
 		},
 	}
 	actual, err := tapmirrors.Create(context.TODO(), fake.ServiceClient(fakeServer), options).Extract()
@@ -84,8 +84,8 @@ func TestCreate(t *testing.T) {
 		MirrorType:  "erspanv1",
 		RemoteIP:    "192.168.54.217",
 		Directions: tapmirrors.Directions{
-			In:  "1",
-			Out: "2",
+			In:  1,
+			Out: 2,
 		},
 	}
 	th.AssertDeepEquals(t, expected, *actual)
@@ -134,8 +134,8 @@ func TestGet(t *testing.T) {
 		MirrorType:  "erspanv1",
 		RemoteIP:    "192.168.54.217",
 		Directions: tapmirrors.Directions{
-			In:  "1",
-			Out: "2",
+			In:  1,
+			Out: 2,
 		},
 	}
 	th.AssertDeepEquals(t, expected, *actual)
@@ -207,8 +207,8 @@ func TestList(t *testing.T) {
 				MirrorType:  "erspanv1",
 				RemoteIP:    "192.168.54.217",
 				Directions: tapmirrors.Directions{
-					In:  "1",
-					Out: "2",
+					In:  1,
+					Out: 2,
 				},
 			},
 		}
@@ -283,8 +283,8 @@ func TestUpdate(t *testing.T) {
 		MirrorType:  "erspanv1",
 		RemoteIP:    "192.168.54.217",
 		Directions: tapmirrors.Directions{
-			In:  "1",
-			Out: "2",
+			In:  1,
+			Out: 2,
 		},
 	}
 	th.AssertDeepEquals(t, expected, *actual)
