core: pass context to the provider.EndpointLocator func#3442
Merged
kayrus merged 1 commit intogophercloud:mainfrom Jul 9, 2025
Merged
core: pass context to the provider.EndpointLocator func#3442kayrus merged 1 commit intogophercloud:mainfrom
kayrus merged 1 commit intogophercloud:mainfrom
Conversation
e8e5312 to
330dbcf
Compare
330dbcf to
2595acd
Compare
Contributor
Author
|
@stephenfin @pierreprinetti @mandre kindly ping |
stephenfin
approved these changes
Jul 3, 2025
Contributor
Author
|
Since not all tests are green, I'd like to receive one more approval before the merge |
Contributor
|
The messaging failures are expected since we are not handling paths as we should. I'm looking into this. The ironic failures are also known: @Sharpz7 is looking into it. The Octavia failures are new though. I'll look at this too. |
stephenfin
added a commit
to shiftstack/gophercloud
that referenced
this pull request
Aug 7, 2025
This is a v2-only alternative to gophercloud#3442 [1] that avoids introducing a breaking function signature change while still resolving gophercloud#3441 [2]. [1] gophercloud#3442 [2] gophercloud#3441 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3441