Added Type into ServiceClient to Distinguish Different Services#341
Closed
pospispa wants to merge 1 commit intogophercloud:masterfrom
Closed
Added Type into ServiceClient to Distinguish Different Services#341pospispa wants to merge 1 commit intogophercloud:masterfrom
pospispa wants to merge 1 commit intogophercloud:masterfrom
Conversation
All ServiceClient methods insert the OpenStack Nova HTTP Microversion header ("X-OpenStack-Nova-API-Version") into HTTP requests even though the request may be to a different service than Nova. This is incorrect.
That's why a mapping of serviceType to HTTPMicroversionHeader is added. Default value (empty string) is mapped to OpenStack Nova HTTP Microversion header because of backward compatibility.
The serviceType constants will be made public as soon as it will be needed.
Closed
Contributor
Author
|
@jtopjian @jrperritt please review |
Contributor
|
I'm not sure this is the best way to implement this. I'll want to read more about it before we merge anything. |
Contributor
Author
|
@jrperritt OK, will wait and looking forward to your comments. |
Merged
Contributor
|
See #355 for my take on how to handle this. |
Contributor
Author
|
Solution in #355 was chosen that's why this PR is closed without merge. |
msheikh-wind
pushed a commit
to msheikh-wind/gophercloud
that referenced
this pull request
May 19, 2025
This commit enables multi-netting configuration for VLAN and Bond network types as well. Previously, only the Ethernet type was checking the configuration. Test Plan [Day 1] - Add admin multi-netting configuration: no changes should be applied. [Day 2] - Add admin multi-netting configuration for the 3 types (Ethernet, VLAN, Bond). The configuration should be applied w/o lock/unlock. Signed-off-by: Hugo Brito <hugo.brito@windriver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All ServiceClient methods insert the OpenStack Nova HTTP Microversion header ("X-OpenStack-Nova-API-Version") into HTTP requests even though the request may be to a different service than Nova. This is incorrect.
That's why a mapping of serviceType to HTTPMicroversionHeader is added. Default value (empty string) is mapped to OpenStack Nova HTTP Microversion header because of backward compatibility.
The serviceType constants will be made public as soon as it will be needed.
Prior to a PR being reviewed, there needs to be a Github issue that the PR
addresses. Replace the brackets and text below with that issue number.
For #53
Links to the line numbers/files in the OpenStack source code that support the
code in this PR: N/A