Fix JSON field name hints in APIVersion structs#3282
Merged
mandre merged 1 commit intogophercloud:mainfrom Feb 3, 2025
Merged
Conversation
`son:"status"` is not a valid hint for JSON (de/en)coder.
There was a problem hiding this comment.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
EmilienM
approved these changes
Jan 15, 2025
Contributor
EmilienM
left a comment
There was a problem hiding this comment.
Thanks.
I've proposed the backports to v2 and v1 as they also have the typo.
mandre
approved these changes
Feb 3, 2025
This was referenced Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
son:"status"is not a valid hint for JSON (de/en)coder.There's no actual issue, everything works as expected - but only because no one ever needs to marshal those APIVersion structs back to JSON.