Skip to content

Add support for disable_power_off#3247

Merged
mandre merged 1 commit intogophercloud:masterfrom
derekhiggins:disable_power_off
Dec 3, 2024
Merged

Add support for disable_power_off#3247
mandre merged 1 commit intogophercloud:masterfrom
derekhiggins:disable_power_off

Conversation

@derekhiggins
Copy link
Copy Markdown
Contributor

Added in baremetal api v1.95 disable_power_off expcicitly prevents a node from being powered off by ironic.

See https://specs.openstack.org/openstack/ironic-specs/specs/approved/nc-si.html

Fixes #3246

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://review.opendev.org/c/openstack/ironic/+/934740

Added in baremetal api v1.95 disable_power_off expcicitly
prevents a node from being powered off by ironic.

See https://specs.openstack.org/openstack/ironic-specs/specs/approved/nc-si.html
@github-actions github-actions bot added edit:baremetal This PR updates baremetal code semver:minor Backwards-compatible change labels Dec 3, 2024
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.

@mandre mandre added the backport-v2 This PR will be backported to v2 label Dec 3, 2024
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 78.681%. remained the same
when pulling bdfd59d on derekhiggins:disable_power_off
into 1fc1ee7 on gophercloud:master.

Copy link
Copy Markdown
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mandre mandre merged commit 994be3b into gophercloud:master Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v2 This PR will be backported to v2 edit:baremetal This PR updates baremetal code semver:minor Backwards-compatible change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for "disable_power_off" missing

3 participants