Added address groups to Networking extensions, with tests.#3218
Merged
kayrus merged 1 commit intogophercloud:mainfrom May 27, 2025
Merged
Added address groups to Networking extensions, with tests.#3218kayrus merged 1 commit intogophercloud:mainfrom
kayrus merged 1 commit intogophercloud:mainfrom
Conversation
There was a problem hiding this comment.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
kayrus
reviewed
Oct 17, 2024
Contributor
kayrus
left a comment
There was a problem hiding this comment.
Hi. Thanks for the PR. A couple of first findings. Probably later I'll take a closer look.
Contributor
Author
|
Hi @kayrus, made the initial changes you'd left, is there an update on this please? |
dda7dcb to
1ceee9e
Compare
7046b27 to
1fe6662
Compare
1fe6662 to
f799e81
Compare
kayrus
previously approved these changes
May 27, 2025
Contributor
kayrus
left a comment
There was a problem hiding this comment.
I rebased your change on main, added functional tests and adjusted the UpdateOpts to not include the Addresses member, otherwise API complains that this field is read-only.
…d to SecGroupRules
f799e81 to
ec5b9ca
Compare
kayrus
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added address groups to Networking extensions, with tests.
Field added to SecGroupRules - Allows security group rule to reference the remote address group as the rule target
Fixes #3200
API:
https://docs.openstack.org/api-ref/network/v2/index.html#address-groups
List:
https://github.com/Jscott377/gophercloud/blob/add_address_groups_to_networking/openstack/networking/v2/extensions/addressgroups/requests.go#L42
Get:
https://github.com/Jscott377/gophercloud/blob/add_address_groups_to_networking/openstack/networking/v2/extensions/addressgroups/requests.go#L108
Create:
https://github.com/Jscott377/gophercloud/blob/add_address_groups_to_networking/openstack/networking/v2/extensions/addressgroups/requests.go#L96
Update:
https://github.com/Jscott377/gophercloud/blob/add_address_groups_to_networking/openstack/networking/v2/extensions/addressgroups/requests.go#L123
Delete:
https://github.com/Jscott377/gophercloud/blob/add_address_groups_to_networking/openstack/networking/v2/extensions/addressgroups/requests.go#L116
Add Addresses:
https://github.com/Jscott377/gophercloud/blob/add_address_groups_to_networking/openstack/networking/v2/extensions/addressgroups/requests.go#L137
RemoveAddresses:
https://github.com/Jscott377/gophercloud/blob/add_address_groups_to_networking/openstack/networking/v2/extensions/addressgroups/requests.go#L151