Skip to content

[v1] baremetal: fix handling of the "fields" query argument#2985

Merged
pierreprinetti merged 1 commit intogophercloud:v1from
shiftstack:backport-2961-v1
Mar 11, 2024
Merged

[v1] baremetal: fix handling of the "fields" query argument#2985
pierreprinetti merged 1 commit intogophercloud:v1from
shiftstack:backport-2961-v1

Conversation

@mandre
Copy link
Copy Markdown
Contributor

@mandre mandre commented Mar 10, 2024

Backport: #2961
Supersedes #2980

Ironic expects a comma-separated string. Add a new feature to BuildQueryString to choose the format of slices.

Closes: #2960

Manual backport since the original change had a different signature for the EachPage() function, where it expected a context.

Ironic expects a comma-separated string. Add a new feature to
BuildQueryString to choose the format of slices.

Closes: gophercloud#2960
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 77.955% (+0.001%) from 77.954%
when pulling b29bd3f on shiftstack:backport-2961-v1
into 7b5fa21 on gophercloud:v1.

@pierreprinetti pierreprinetti added the backport-v1 This PR will be backported to v1 label Mar 11, 2024
@pierreprinetti pierreprinetti removed the backport-v1 This PR will be backported to v1 label Mar 11, 2024
@pierreprinetti pierreprinetti merged commit 3fbc1e6 into gophercloud:v1 Mar 11, 2024
@pierreprinetti pierreprinetti deleted the backport-2961-v1 branch March 11, 2024 09:44
@pierreprinetti pierreprinetti added the v1 This PR targets v1 label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:patch No API change v1 This PR targets v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants