baremetal: fix handling of the "fields" query argument#2961
Merged
mandre merged 1 commit intogophercloud:masterfrom Mar 9, 2024
Merged
baremetal: fix handling of the "fields" query argument#2961mandre merged 1 commit intogophercloud:masterfrom
mandre merged 1 commit intogophercloud:masterfrom
Conversation
79467aa to
33032be
Compare
mandre
reviewed
Mar 8, 2024
Contributor
mandre
left a comment
There was a problem hiding this comment.
LGTM. This is a rather elegant solution and I quite like it.
mandre
previously approved these changes
Mar 8, 2024
Contributor
Author
To be clear, I obvious did NOT do that :-/ (I miss gerrit so much) |
Contributor
Let me try again, otherwise you might need a rebase after #2964 merged. |
mandre
previously approved these changes
Mar 8, 2024
Ironic expects a comma-separated string. Add a new feature to BuildQueryString to choose the format of slices. Closes: gophercloud#2960
33032be to
6cbf38d
Compare
mandre
approved these changes
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ironic expects a comma-separated string. Add a new feature to
BuildQueryString to choose the format of slices.
Closes: #2960