Make Gophercloud context-aware#2936
Merged
EmilienM merged 1 commit intogophercloud:masterfrom Feb 26, 2024
Merged
Conversation
3fc79f4 to
8e7db54
Compare
877427d to
dcf4ee2
Compare
76d791d to
63d184f
Compare
63d184f to
73878e4
Compare
73878e4 to
858e146
Compare
21b5b36 to
e767047
Compare
e767047 to
a6b9d27
Compare
a6b9d27 to
0623dcb
Compare
With this change, all functions and methods that trigger an HTTP call now accept an instance of `context.Context` as their first argument. This breaking change enables cancellation and tracing to be used across all packages of the library. Co-Authored-By: Stefan Majewsky <stefan.majewsky@sap.com> Co-Authored-By: Pierre Prinetti <pierreprinetti@redhat.com>
0623dcb to
1b7c1ce
Compare
Member
Author
|
This should be good to go @gophercloud/core |
EmilienM
approved these changes
Feb 26, 2024
Contributor
EmilienM
left a comment
There was a problem hiding this comment.
Nice work, let's ship it now and if something was missed we can fix it on the go.
Merged
mandre
added a commit
to shiftstack/gophercloud
that referenced
this pull request
Mar 10, 2024
A follow-up to gophercloud#2936 that missed part of the `internal/acceptance/openstack/networking/v2/extensions/fwaas_v2/groups_test.go` file. Fixes gophercloud#2981
mandre
added a commit
to shiftstack/gophercloud
that referenced
this pull request
Mar 11, 2024
A follow-up to gophercloud#2936 that missed part of the `internal/acceptance/openstack/networking/v2/extensions/fwaas_v2/groups_test.go` file. Fixes gophercloud#2981
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, all functions and methods that trigger an HTTP call
now accept an instance of
context.Contextas their first argument.This breaking change enables cancellation and tracing to be used across
all packages of the library.
Co-Authored-By: @majewsky
Co-Authored-By: @pierreprinetti