[v1] Context-aware methods to ProviderClient and ServiceClient#2884
Merged
pierreprinetti merged 1 commit intogophercloud:v1from Feb 2, 2024
Merged
[v1] Context-aware methods to ProviderClient and ServiceClient#2884pierreprinetti merged 1 commit intogophercloud:v1from
pierreprinetti merged 1 commit intogophercloud:v1from
Conversation
40fece3 to
0bb8600
Compare
0bb8600 to
889f21e
Compare
889f21e to
e8bd3c5
Compare
e8bd3c5 to
843afd9
Compare
EmilienM
previously approved these changes
Feb 1, 2024
843afd9 to
6d76275
Compare
6d76275 to
2630165
Compare
Member
Author
|
One last change: Moved the context-merging function to an |
0984d6a to
276dd63
Compare
276dd63 to
72f537b
Compare
EmilienM
previously approved these changes
Feb 1, 2024
mandre
reviewed
Feb 2, 2024
| ) | ||
|
|
||
| func TestMerge(t *testing.T) { | ||
| t.Run("returns values from both parents", func(t *testing.T) { |
Contributor
There was a problem hiding this comment.
Let's just add a test for values that take precedence, as in #2883.
Provide new methods to leverage per-call `context.Context`. This patch, suitable to be merged to `v1`, vendors the context package from the v1.21 standard library, to make `AfterFunc` available.
72f537b to
ef06ea2
Compare
EmilienM
approved these changes
Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide new methods to leverage per-call
context.Context.Backports #2883
This patch, suitable to be merged to
v1, vendors the context package from the v1.21 standard library, to makeAfterFuncavailable.