Context-aware methods to ProviderClient and ServiceClient#2883
Merged
pierreprinetti merged 1 commit intogophercloud:masterfrom Feb 2, 2024
Merged
Context-aware methods to ProviderClient and ServiceClient#2883pierreprinetti merged 1 commit intogophercloud:masterfrom
pierreprinetti merged 1 commit intogophercloud:masterfrom
Conversation
e524823 to
70a81cf
Compare
70a81cf to
a2376c8
Compare
a2376c8 to
87da7b3
Compare
87da7b3 to
693705c
Compare
693705c to
d57a350
Compare
Member
Author
|
This PR has been mentioned in the Gophercloud Slack channel: https://kubernetes.slack.com/archives/C05G4NJ6P6X/p1706708314206099 |
EmilienM
previously approved these changes
Jan 31, 2024
d57a350 to
9854a47
Compare
9854a47 to
4240f51
Compare
Member
Author
|
One last change: Moved the context-merging function to an |
c1cae60 to
1b15d36
Compare
1b15d36 to
b30cdff
Compare
b30cdff to
d91761a
Compare
d91761a to
52ab14b
Compare
52ab14b to
0f1c3c7
Compare
EmilienM
previously approved these changes
Feb 1, 2024
mandre
reviewed
Feb 2, 2024
Contributor
mandre
left a comment
There was a problem hiding this comment.
Thanks @pierreprinetti, I don't think that dropping the values from the second context is a big problem in practice so I'm fine starting with the current implementation and revisit if we find this is a blocking issue. This is already a huge step forward.
provider_client.go
Outdated
|
|
||
| // Context is the context passed to the HTTP request. | ||
| // Context is the context passed to the HTTP request. Values set on the | ||
| // per-call context, when available, override valus set on this |
Contributor
There was a problem hiding this comment.
Just a nit, feel free to ignore.
Suggested change
| // per-call context, when available, override valus set on this | |
| // per-call context, when available, override values set on this |
internal/ctxt/merge_test.go
Outdated
| t.Run("returns values from both parents", func(t *testing.T) { | ||
| ctx, cancel := ctxt.Merge( | ||
| context.WithValue(context.Background(), "key1", "value1"), | ||
| context.WithValue(context.Background(), "key2", "value2"), |
Contributor
There was a problem hiding this comment.
Can you perhaps also check that the value from the first context takes precedence when the second context holds the same key? If this is a behavior that we're going to support, then we should have tests for it so that we avoid regressions.
Member
Author
There was a problem hiding this comment.
this is a good idea, thanks
Provide new methods to leverage per-call `context.Context`.
0f1c3c7 to
b49ce37
Compare
This was referenced Feb 2, 2024
EmilienM
approved these changes
Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide new methods to leverage per-call
context.Context.In the http.Request resulting from using these new context-aware calls, the per-call context values take precendence over the ProviderClient's.
Cancellation obeys both the per-call context and the ProviderClient's.