Make fixtures part of tests#2811
Merged
pierreprinetti merged 1 commit intogophercloud:masterfrom Oct 16, 2023
Merged
Conversation
By renaming the fixtures to `fixtures_test`, we mark them as test, and no
longer part of the public API.
Some files were left out as they were included in other tests:
$ grep "/testing" -R openstack | cut -d " " -f 2 | sort | uniq
"github.com/gophercloud/gophercloud/openstack/baremetalintrospection/v1/introspection/testing"
"github.com/gophercloud/gophercloud/openstack/baremetal/inventory/testing"
"github.com/gophercloud/gophercloud/openstack/common/extensions/testing"
"github.com/gophercloud/gophercloud/openstack/identity/v3/tokens/testing"
"github.com/gophercloud/gophercloud/openstack/networking/v2/extensions/layer3/floatingips/testing"
"github.com/gophercloud/gophercloud/openstack/networking/v2/networks/testing"
"github.com/gophercloud/gophercloud/openstack/networking/v2/ports/testing"
"github.com/gophercloud/gophercloud/openstack/objectstorage/v1/accounts/testing"
"github.com/gophercloud/gophercloud/openstack/objectstorage/v1/containers/testing"
This should prevent `go-apidiff` from complaining when modifying
fixtures.
Member
|
LGTM in principle; let's see what the CI thinks of that. |
pierreprinetti
approved these changes
Oct 16, 2023
Member
pierreprinetti
left a comment
There was a problem hiding this comment.
Baremetal fails in the deployment phase
|
Labels |
mandre
added a commit
to shiftstack/gophercloud
that referenced
this pull request
Mar 22, 2024
The PR removing the code for CDN [1] merged around the same time the fixtures were modified to no longer be part of the public API [2], causing these files to stay in the tree. This commit cleans up files that shouldn't be here. [1] gophercloud#2809 [2] gophercloud#2811
Merged
This was referenced Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By renaming the fixtures to
fixtures_test, we mark them as test, and no longer part of the public API.Some files were left out as they were included in other tests:
This should prevent
go-apidifffrom complaining when modifying fixtures.