[v1] Acceptance: Handle numerical version names in version comparison helpers#2785
Merged
[v1] Acceptance: Handle numerical version names in version comparison helpers#2785
Conversation
Rename to IsCurrentBelow() and IsCurrentAbove() respectively.
Take into account numerical release names, after zed, and ensure that comparing the same version always yields false.
EmilienM
approved these changes
Sep 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport: #2764
There are two changes here:
IsReleasesBelow()andIsReleasesAbove()functions toIsCurrentBelow()andIsCurrentAbove()respectively.comparing the same version always yields false. Also fixing bugs when comparing to master and add comprehensive tests.