Acceptance: Handle numerical version names in version comparison helpers#2764
Acceptance: Handle numerical version names in version comparison helpers#2764EmilienM merged 2 commits intogophercloud:masterfrom
Conversation
|
I changed the label manually before our workflow doesn't know (yet) that it's acceptance and that API is not maintained here. |
| @@ -0,0 +1,66 @@ | |||
| //go:build acceptance | |||
| // +build acceptance | |||
There was a problem hiding this comment.
Please put that file into a testing directory or this will be skipped by the unittest (in fact coverage) job. See
Line 6 in 4f6d145
c157f91 to
69d9d05
Compare
|
The go-apidiff failure should be fixed with joelanford/go-apidiff@0511785. Waiting for a new release. |
no, you'll need to rebase your PR on top of #2773 once merged, and the job will be happy. However the job will set the label to |
joelanford/go-apidiff#36 will help. |
Rename to IsCurrentBelow() and IsCurrentAbove() respectively.
69d9d05 to
8de831b
Compare
Take into account numerical release names, after zed, and ensure that comparing the same version always yields false.
8de831b to
5819dc0
Compare
There are two changes here:
IsReleasesBelow()andIsReleasesAbove()functions toIsCurrentBelow()andIsCurrentAbove()respectively.comparing the same version always yields false. Also fixing bugs when comparing to master and add comprehensive tests.