ci/semver-auto: return a failure only when needed#2765
Merged
pierreprinetti merged 1 commit intogophercloud:masterfrom Sep 8, 2023
Merged
ci/semver-auto: return a failure only when needed#2765pierreprinetti merged 1 commit intogophercloud:masterfrom
pierreprinetti merged 1 commit intogophercloud:masterfrom
Conversation
When go-apidiff returns semver=major, it returns RC=1 which causes the workflow to return an error while we don't want that, we just want the label to be applied. Instead, let's ignore that error so the label can be set later and add a step to check if an error occured and semver is not major, then it's an actual problem that we should check in the logs (e.g. an issue when running go-apidiff).
Contributor
Author
|
Note: this won't be backported because in v1 we don't want semver:major anyway. |
pierreprinetti
approved these changes
Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When go-apidiff returns semver=major, it returns RC=1 which causes the
workflow to return an error while we don't want that, we just want the
label to be applied.
Instead, let's ignore that error so the label can be set later and add a
step to check if an error occured and semver is not major, then it's an
actual problem that we should check in the logs (e.g. an issue when
running go-apidiff).