Skip to content

Cinder: Remove multiatttach request parameter#2665

Merged
EmilienM merged 1 commit intogophercloud:masterfrom
shiftstack:remove-multiattach
Jul 20, 2023
Merged

Cinder: Remove multiatttach request parameter#2665
EmilienM merged 1 commit intogophercloud:masterfrom
shiftstack:remove-multiattach

Conversation

@mandre
Copy link
Copy Markdown
Contributor

@mandre mandre commented Jun 30, 2023

The multiattach request parameter is no longer part of the API [1]. Starting with microversion 3.50 (Queens), you need to use a volume type with multiattach capability instead.

Depends on #2658.

[1] openstack/cinder@d4535c7

@mandre mandre added the semver:major Breaking change label Jun 30, 2023
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 30, 2023

Coverage Status

coverage: 79.099%. remained the same when pulling 7653bb5 on shiftstack:remove-multiattach into 1b8e9af on gophercloud:master.

@EmilienM
Copy link
Copy Markdown
Contributor

We should update the unit tests.

@EmilienM
Copy link
Copy Markdown
Contributor

any update on this one?

The multiattach request parameter is no longer part of the API [1].
Starting with microversion 3.50 (Queens), you need to use a volume type
with multiattach capability instead.

Depends on gophercloud#2658.

[1] openstack/cinder@d4535c7
@mandre mandre force-pushed the remove-multiattach branch from ab98c2b to 7653bb5 Compare July 20, 2023 01:47
@github-actions github-actions bot removed the semver:major Breaking change label Jul 20, 2023
@mandre mandre added the semver:major Breaking change label Jul 20, 2023
@mandre
Copy link
Copy Markdown
Contributor Author

mandre commented Jul 20, 2023

We should update the unit tests.

It needed a rebase after #2658 merged. The tests are now green.

@EmilienM EmilienM merged commit 807ac8c into gophercloud:master Jul 20, 2023
@EmilienM EmilienM deleted the remove-multiattach branch July 20, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:major Breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants