Skip to content

tests: run MultiAttach with a capable Cinder Type#2658

Merged
mandre merged 1 commit intogophercloud:masterfrom
shiftstack:issue-2657
Jun 30, 2023
Merged

tests: run MultiAttach with a capable Cinder Type#2658
mandre merged 1 commit intogophercloud:masterfrom
shiftstack:issue-2657

Conversation

@EmilienM
Copy link
Copy Markdown
Contributor

@EmilienM EmilienM commented Jun 28, 2023

Starting from the Queens release, it is possible to attach a volume to
multiple hosts/servers, using a volume type with multiattach capability.

Cinder previously had a multiattach parameter that could be passed
during the volume creation. This parameter was recently removed [1], and
caused our jobs to fail.

This commit change the tests to no longer use the removed parameter.

Fixes #2657.

[1] openstack/cinder@d4535c7

@EmilienM EmilienM self-assigned this Jun 28, 2023
@EmilienM
Copy link
Copy Markdown
Contributor Author

@stephenfin for a second pair of eyes.

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 28, 2023

Coverage Status

coverage: 79.085%. remained the same when pulling cf6531e on shiftstack:issue-2657 into 9530e9b on gophercloud:master.

@EmilienM
Copy link
Copy Markdown
Contributor Author

from the logs, it has created a multiattach backend but now I need to update the test to use that backend:

2023-06-28T20:01:55.3033614Z + lib/cinder:create_one_type:654           :   openstack --os-region-name=RegionOne volume type create --property 'multiattach=<is> True' multiattach
2023-06-28T20:01:57.9631871Z +-------------+--------------------------------------+
2023-06-28T20:01:57.9632319Z | Field       | Value                                |
2023-06-28T20:01:57.9632752Z +-------------+--------------------------------------+
2023-06-28T20:01:57.9634062Z | description | None                                 |
2023-06-28T20:01:57.9634504Z | id          | cce9c3dd-bad0-4d1b-8e2d-8dc25ec5f406 |
2023-06-28T20:01:57.9634855Z | is_public   | True                                 |
2023-06-28T20:01:57.9635445Z | name        | multiattach                          |
2023-06-28T20:01:57.9635861Z | properties  | multiattach='<is> True'              |
2023-06-28T20:01:57.9636274Z +-------------+--------------------------------------+

I'll look at it.

@EmilienM EmilienM changed the title CI/blockstorage: enable multiattach tests: run MultiAttach with a capable Cinder Type Jun 29, 2023
@EmilienM EmilienM added semver:patch No API change backport-v1 This PR will be backported to v1 labels Jun 29, 2023
@github-actions github-actions bot removed the semver:patch No API change label Jun 29, 2023
@EmilienM EmilienM force-pushed the issue-2657 branch 2 times, most recently from a5ca2ef to dbb1e7f Compare June 30, 2023 02:08
@EmilienM EmilienM added the semver:patch No API change label Jun 30, 2023
@github-actions github-actions bot removed the semver:patch No API change label Jun 30, 2023
Starting from the Queens release, it is possible to attach a volume to
multiple hosts/servers, using a volume type with multiattach capability.

Cinder previously had a `multiattach` parameter that could be passed
during the volume creation. This parameter was recently removed [1], and
caused our jobs to fail.

This commit change the tests to no longer use the removed parameter.

Fixes gophercloud#2657.

Co-Authored-By: Martin André <m.andre@redhat.com>

[1] openstack/cinder@d4535c7
@mandre
Copy link
Copy Markdown
Contributor

mandre commented Jun 30, 2023

I'm considering removing the multiattach param from the volume creation request as well, but this will break API compatibility, so will handle that in a separate PR so we can backport this one.

mandre added a commit to shiftstack/gophercloud that referenced this pull request Jun 30, 2023
The multiattach request parameter is no longer part of the API [1].
Starting with microversion 3.50 (Queens), you need to use a volume type
with multiattach capability instead.

Depends on gophercloud#2658.

openstack/cinder@d4535c7
mandre added a commit to shiftstack/gophercloud that referenced this pull request Jun 30, 2023
The multiattach request parameter is no longer part of the API [1].
Starting with microversion 3.50 (Queens), you need to use a volume type
with multiattach capability instead.

Depends on gophercloud#2658.

[1] openstack/cinder@d4535c7
@mandre mandre added the semver:patch No API change label Jun 30, 2023
@mandre mandre merged commit 496af9b into gophercloud:master Jun 30, 2023
@mandre mandre deleted the issue-2657 branch June 30, 2023 07:22
github-actions bot pushed a commit that referenced this pull request Jun 30, 2023
tests: run MultiAttach with a capable Cinder Type
@pierreprinetti pierreprinetti removed the backport-v1 This PR will be backported to v1 label Jun 30, 2023
mandre added a commit to shiftstack/gophercloud that referenced this pull request Jul 20, 2023
The multiattach request parameter is no longer part of the API [1].
Starting with microversion 3.50 (Queens), you need to use a volume type
with multiattach capability instead.

Depends on gophercloud#2658.

[1] openstack/cinder@d4535c7
@mandre mandre added the backport-v1 This PR will be backported to v1 label Jul 20, 2023
@EmilienM EmilienM added backport-v1 This PR will be backported to v1 and removed backport-v1 This PR will be backported to v1 labels Aug 1, 2023
@mandre mandre added backport-v1 This PR will be backported to v1 and removed backport-v1 This PR will be backported to v1 labels Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v1 This PR will be backported to v1 semver:patch No API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: TestVolumesMultiAttach permafailing

4 participants