tests: run MultiAttach with a capable Cinder Type#2658
Merged
mandre merged 1 commit intogophercloud:masterfrom Jun 30, 2023
Merged
tests: run MultiAttach with a capable Cinder Type#2658mandre merged 1 commit intogophercloud:masterfrom
mandre merged 1 commit intogophercloud:masterfrom
Conversation
Contributor
Author
|
@stephenfin for a second pair of eyes. |
Contributor
Author
|
from the logs, it has created a multiattach backend but now I need to update the test to use that backend: I'll look at it. |
a5ca2ef to
dbb1e7f
Compare
Starting from the Queens release, it is possible to attach a volume to multiple hosts/servers, using a volume type with multiattach capability. Cinder previously had a `multiattach` parameter that could be passed during the volume creation. This parameter was recently removed [1], and caused our jobs to fail. This commit change the tests to no longer use the removed parameter. Fixes gophercloud#2657. Co-Authored-By: Martin André <m.andre@redhat.com> [1] openstack/cinder@d4535c7
Contributor
|
I'm considering removing the |
mandre
added a commit
to shiftstack/gophercloud
that referenced
this pull request
Jun 30, 2023
The multiattach request parameter is no longer part of the API [1]. Starting with microversion 3.50 (Queens), you need to use a volume type with multiattach capability instead. Depends on gophercloud#2658. openstack/cinder@d4535c7
mandre
added a commit
to shiftstack/gophercloud
that referenced
this pull request
Jun 30, 2023
The multiattach request parameter is no longer part of the API [1]. Starting with microversion 3.50 (Queens), you need to use a volume type with multiattach capability instead. Depends on gophercloud#2658. [1] openstack/cinder@d4535c7
mandre
approved these changes
Jun 30, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jun 30, 2023
tests: run MultiAttach with a capable Cinder Type
mandre
added a commit
to shiftstack/gophercloud
that referenced
this pull request
Jul 20, 2023
The multiattach request parameter is no longer part of the API [1]. Starting with microversion 3.50 (Queens), you need to use a volume type with multiattach capability instead. Depends on gophercloud#2658. [1] openstack/cinder@d4535c7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from the Queens release, it is possible to attach a volume to
multiple hosts/servers, using a volume type with multiattach capability.
Cinder previously had a
multiattachparameter that could be passedduring the volume creation. This parameter was recently removed [1], and
caused our jobs to fail.
This commit change the tests to no longer use the removed parameter.
Fixes #2657.
[1] openstack/cinder@d4535c7