Instrument backporting to v1#2656
Merged
EmilienM merged 1 commit intogophercloud:masterfrom Jun 29, 2023
Merged
Conversation
The stable branch is now `v1`. Non-breaking changes will be backported by applying a `backport-v1` label.
c44a154 to
699d600
Compare
EmilienM
approved these changes
Jun 28, 2023
Contributor
|
I don't know if/how you are able to test it but from a first look, it's good to me. |
Member
Author
I have tested it in github.com/pierreprinetti/gophtest and it seemed OK. I’d say that if you agree with the change in principle, we can merge and go ahead. I guess we can deal with unexpected issues as they come |
pierreprinetti
added a commit
to shiftstack/gophercloud
that referenced
this pull request
Jun 29, 2023
The PR gophercloud#2656 caused all labels to be removed, because each run of the action eliminates all labels that aren't listed. This PR reintroduces our semver labels and the `good first issue` label in the repository.
pierreprinetti
added a commit
to shiftstack/gophercloud
that referenced
this pull request
Jun 29, 2023
The PR gophercloud#2656 caused all labels to be removed, because each run of the action eliminates all labels that aren't listed. This PR reintroduces our semver labels and the `good first issue` label in the repository.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stable branch is now
v1. Non-breaking changes will be backported by applying abackport-v1label.