Implement errors.Unwrap() on unexpected status code errors#2639
Merged
mandre merged 1 commit intogophercloud:masterfrom Jun 6, 2023
Merged
Implement errors.Unwrap() on unexpected status code errors#2639mandre merged 1 commit intogophercloud:masterfrom
mandre merged 1 commit intogophercloud:masterfrom
Conversation
With this patch, we add a method with signature `Unwrap() error` to all
errors signaling an unexpected status code. All of them contain a value
of type `gophercloud.ErrUnexpectedStatusCode` that exposes, among other
useful values, the body of the response sent by the server.
To access the response body of a request that resulted in an unexpected
response code, try to unwrap the returned error to
`gophercloud.ErrUnexpectedStatusCode`:
```Go
pages, err := containers.List(client, nil).AllPages()
if err != nil {
var responseCodeError gophercloud.ErrUnexpectedResponseCode
if errors.As(err, &responseCodeError) {
log.Printf("unexpected response code. Response body:\n---\n%s\n---", responseCodeError.Body)
} else {
log.Printf("unknown error")
}
}
```
ed9f9dc to
86ed770
Compare
mandre
approved these changes
Jun 6, 2023
majewsky
added a commit
to sapcc/limes
that referenced
this pull request
Jun 21, 2023
This affords simplification of our error unpacking by using <gophercloud/gophercloud#2639>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this patch, we add a method with signature
Unwrap() errorto all errors signaling an unexpected status code. All of them contain a value of typegophercloud.ErrUnexpectedStatusCodethat exposes, among other useful values, the body of the response sent by the server.To access the response body of a request that resulted in an unexpected response code, try to unwrap the returned error to
gophercloud.ErrUnexpectedStatusCode:Fixes #2605