Add the ability to remove ingress/egress policies from fwaas_v2 groups#2623
Merged
mandre merged 1 commit intogophercloud:masterfrom May 25, 2023
Koodt:fwaas_v2_add_policies_removing_from_groups
Merged
Add the ability to remove ingress/egress policies from fwaas_v2 groups#2623mandre merged 1 commit intogophercloud:masterfrom Koodt:fwaas_v2_add_policies_removing_from_groups
mandre merged 1 commit intogophercloud:masterfrom
Koodt:fwaas_v2_add_policies_removing_from_groups
Conversation
There was a problem hiding this comment.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
mandre
reviewed
May 22, 2023
| IngressFirewallPolicyID *string `json:"ingress_firewall_policy_id"` | ||
| } | ||
|
|
||
| func RemoveIngressPolicy(c *gophercloud.ServiceClient, id string) (r UpdateResult) { |
Contributor
There was a problem hiding this comment.
I wonder if these two functions are actually required to remove policies from firewall groups.
Have you tried setting the IngressFirewallPolicyID field to the empty string?
https://go.dev/play/p/iSM7DNmzUej
Contributor
Author
There was a problem hiding this comment.
Firewall policy ID must be nil or UUID
Empty string leads to exception at the Openstack side.
Reason: '[]' is not a valid UUID."
Reason: '' is not a valid UUID."
Reason: 'false' is not a valid UUID."
Add RemoveIngressPolicy, RemoveEgressPolicy functions. Add acceptance tests. Add unit tests.
mandre
approved these changes
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add RemoveIngressPolicy, RemoveEgressPolicy functions.
Add acceptance tests.
Add unit tests.
Fixes #2622