Skip to content

Add missing rule protocol constants for IPIP#2583

Merged
mandre merged 3 commits intogophercloud:masterfrom
mikejoh:add-missing-protocol-constants
Mar 14, 2023
Merged

Add missing rule protocol constants for IPIP#2583
mandre merged 3 commits intogophercloud:masterfrom
mikejoh:add-missing-protocol-constants

Conversation

@mikejoh
Copy link
Copy Markdown
Contributor

@mikejoh mikejoh commented Mar 6, 2023

Fixes #2582

@mikejoh mikejoh marked this pull request as ready for review March 6, 2023 22:26
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 6, 2023 •
edited
Loading

Coverage Status

Coverage: 79.145% (-1.09%) from 80.237% when pulling fd15d0c on mikejoh:add-missing-protocol-constants into 7edb0d0 on gophercloud:master.

@mikejoh mikejoh mentioned this pull request Mar 7, 2023
Closed
mandre
mandre reviewed Mar 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ip and hopopt protocols are not documented in https://docs.openstack.org/api-ref/network/v2/?expanded=create-security-group-rule-detail#create-security-group-rule. They also share the same number 0. Are they aliases to the any protocol?

@mikejoh
Copy link
Copy Markdown
Contributor Author

mikejoh commented Mar 14, 2023

The ip and hopopt protocols are not documented in https://docs.openstack.org/api-ref/network/v2/?expanded=create-security-group-rule-detail#create-security-group-rule. They also share the same number 0. Are they aliases to the any protocol?

Good catch, my bad, i didn't check the protocols numbers.. I think that ipip, which has it's owned assigned unique number would make sense to add though. I think i'll change the scope of this PR and the related issue to only add ipip.

@mikejoh mikejoh changed the title Add missing rule protocol constants Add missing rule protocol constants for IPIP Mar 14, 2023
@mandre mandre added this to the v1.3.0 milestone Mar 14, 2023
mandre
mandre approved these changes Mar 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@mandre mandre merged commit a1187d3 into gophercloud:master Mar 14, 2023
@mikejoh mikejoh mentioned this pull request Mar 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.3.0

Development

Successfully merging this pull request may close these issues.

Missing SG rule protocol constant for IPIP

3 participants

@mikejoh @coveralls @mandre