-
Notifications
You must be signed in to change notification settings - Fork 583
Missing SG rule protocol constant for IPIP #2582
Copy link
Copy link
Closed
Description
I noticed that Neutron (on Wallaby) returned the following list of protocols when providing a missing/unsupported protocol:
{"NeutronError": {"type": "SecurityGroupRuleInvalidProtocol", "message": "Security group rule protocol -1 not supported. Only protocol values [None, 'ah', 'dccp', 'egp', 'esp', 'gre', 'hopopt', 'icmp', 'igmp', 'ip', 'ipip', 'ipv6-encap', 'ipv6-frag', 'ipv6-icmp', 'icmpv6', 'ipv6-nonxt', 'ipv6-opts', 'ipv6-route', 'ospf', 'pgm', 'rsvp', 'sctp', 'tcp', 'udp', 'udplite', 'vrrp'] and integer representations [0 to 255] are supported.", "detail": ""}
By comparing the lists of Neutron supported protocols i saw that we miss:
ipip
In the CreateOpts constant list here:
| const ( | |
| DirIngress RuleDirection = "ingress" | |
| DirEgress RuleDirection = "egress" | |
| EtherType4 RuleEtherType = "IPv4" | |
| EtherType6 RuleEtherType = "IPv6" | |
| ProtocolAH RuleProtocol = "ah" | |
| ProtocolDCCP RuleProtocol = "dccp" | |
| ProtocolEGP RuleProtocol = "egp" | |
| ProtocolESP RuleProtocol = "esp" | |
| ProtocolGRE RuleProtocol = "gre" | |
| ProtocolICMP RuleProtocol = "icmp" | |
| ProtocolIGMP RuleProtocol = "igmp" | |
| ProtocolIPv6Encap RuleProtocol = "ipv6-encap" | |
| ProtocolIPv6Frag RuleProtocol = "ipv6-frag" | |
| ProtocolIPv6ICMP RuleProtocol = "ipv6-icmp" | |
| ProtocolIPv6NoNxt RuleProtocol = "ipv6-nonxt" | |
| ProtocolIPv6Opts RuleProtocol = "ipv6-opts" | |
| ProtocolIPv6Route RuleProtocol = "ipv6-route" | |
| ProtocolOSPF RuleProtocol = "ospf" | |
| ProtocolPGM RuleProtocol = "pgm" | |
| ProtocolRSVP RuleProtocol = "rsvp" | |
| ProtocolSCTP RuleProtocol = "sctp" | |
| ProtocolTCP RuleProtocol = "tcp" | |
| ProtocolUDP RuleProtocol = "udp" | |
| ProtocolUDPLite RuleProtocol = "udplite" | |
| ProtocolVRRP RuleProtocol = "vrrp" | |
| ProtocolAny RuleProtocol = "any" | |
| ) |
Links:
- From the
neutron-lib: https://github.com/openstack/neutron-lib/blob/master/neutron_lib/constants.py#L153-L180 - From the official OpenStack Neutron API ref: https://docs.openstack.org/api-ref/network/v2/?expanded=create-security-group-rule-detail#create-security-group-rule
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels