Coverage: 80.234% (+0.1%) from 80.093% when pulling ebf9f9c on kayrus:swift-versioning into e7de1a3 on gophercloud:master.

@EmilienM looks like versioning is not supported in testing env. Can you run functional tests in your env? I'll probably skip the tests.

@mandre @pierreprinetti could you please review this PR?

@mandre @pierreprinetti could you please review this PR?

Thanks for the PR, will look today or tomorrow.

@EmilienM looks like versioning is not supported in testing env. Can you run functional tests in your env? I'll probably skip the tests.

This is odd, the CI environment should enable the object versioning. The CI logs read:

iniset /etc/swift/proxy-server.conf filter:versioned_writes allow_versioned_writes true

What was the issue exactly?

This is odd, the CI environment should enable the object versioning.

these are two legacy implementations of the object versioning. See https://docs.openstack.org/swift/latest/middleware.html#module-swift.common.middleware.versioned_writes.object_versioning for details.

To enable this new mode in a Swift cluster the versioned_writes and symlink middlewares must be added to the proxy pipeline, you must also set the option allow_object_versioning to True

I see... Swift CI enables it via https://github.com/openstack/swift/blob/c0483c5b940d559b4a9efd2b5c64bf5b5528fa11/roles/dsvm-additional-middlewares/tasks/main.yaml#L32-L38

@mandre I don't understand, is it enabled in test env?

@mandre I don't understand, is it enabled in test env?

Not at the moment, I'm trying to see how we could enable it in our CI.

@kayrus Try to add the following to the conf_overrides for swift job and see if it makes a difference:

[[post-config|$SWIFT_CONFIG_PROXY_SERVER]]                                                                                                                  
[filter:versioned_writes]
allow_object_versioning = True

Done, let's see the results...

Still doesn't work

I'm building a devstack environment to test myself. Worst case, we'll merge with the acceptance test skipped like you did originally and try to get the env ready to run it as a follow-up.

I was able to run the tests successfully with a local devstack I deployed using the same snippet so I'm fairly confident this works on master. I'll look at the patch in more details tomorrow.

For the record, here's the local.conf I used:

[[local|localrc]]
ADMIN_PASSWORD=password
DATABASE_PASSWORD=password
RABBIT_PASSWORD=password
SERVICE_PASSWORD=password
USE_PYTHON3=True
INSTALL_TEMPEST=False
SWIFT_HASH=1234123412341234
SWIFT_ENABLE_TEMPURLS=True
SWIFT_TEMPURL_KEY=secretkey
ENABLED_SERVICES+=",-horizon,-dstat,-tempest,s-account,s-container,s-object,s-proxy"
[[post-config|$SWIFT_CONFIG_PROXY_SERVER]]
[filter:versioned_writes]
allow_object_versioning = true

I skip the tests.