Skip to content

Support value_specs for Ports#2537

Merged
mandre merged 1 commit intogophercloud:masterfrom
Nordix:port-value-specs
Jan 24, 2023
Merged

Support value_specs for Ports#2537
mandre merged 1 commit intogophercloud:masterfrom
Nordix:port-value-specs

Conversation

@lentzi90
Copy link
Copy Markdown
Contributor

@lentzi90 lentzi90 commented Jan 24, 2023

Fixes #2532

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

Docs: https://docs.openstack.org/heat/zed/template_guide/openstack.html#OS::Neutron::Port-prop-value_specs

This replaces #2535 because a branch name with / is hard to use with go modules...

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage: 80.086%. Remained the same when pulling 14f8f68 on Nordix:port-value-specs into d68edf4 on gophercloud:master.

@pierreprinetti
Copy link
Copy Markdown
Member

LGTM! @mandre any concerns?

Copy link
Copy Markdown
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @mandre any concerns?

No, I don't see any concers with implementing value_specs for ports.

Thanks for the patch @lentzi90.

@mandre mandre merged commit 15a9feb into gophercloud:master Jan 24, 2023
@lentzi90 lentzi90 deleted the port-value-specs branch January 25, 2023 06:22
@pierreprinetti pierreprinetti added this to the v1.2.0 milestone Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: Support value_specs for ports

4 participants