Conversation
There was a problem hiding this comment.
Thank you for submitting your first PR! Be sure that we will be looking at it but keep in mind
this sometimes takes a while.
Please let the maintainers know if your PR has not got enough attention after a few days.
If any doubt, please consult our PR tutorial.
| DeviceOwner *string `json:"device_owner,omitempty"` | ||
| SecurityGroups *[]string `json:"security_groups,omitempty"` | ||
| AllowedAddressPairs *[]AddressPair `json:"allowed_address_pairs,omitempty"` | ||
| ValueSpecs map[string]string `json:"value_specs,omitempty"` |
There was a problem hiding this comment.
I know it's horrible, but could you please change this field to be a pointer?
Before your change, UpdateOpts is comparable. Having it as a pointer would keep it comparable, and thus would not break compilation of any consumer code.
There was a problem hiding this comment.
Argh... messed up the branches. go mod does not like branches with / in the name, and I'm using the branch here for a PR in CAPO (kubernetes-sigs/cluster-api-provider-openstack#1452), which means I had to change the branch name.
I will create a new PR with the correct branch name.
There was a problem hiding this comment.
Ok, thanks! I am closing this one to avoid confusion.
There was a problem hiding this comment.
The new PR is #2537. It has the same content (with the fixed the pointer). Sorry for the mess.
Ref for go issue with slashes in branch names: golang/go#32955 (comment)
Fixes #2532
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
Docs: https://docs.openstack.org/heat/zed/template_guide/openstack.html#OS::Neutron::Port-prop-value_specs