Merged
Conversation
Update the depedency to the last commit that is compatible with Go v1.14. The [next commit][1] replaces calls to `io/ioutil` to its replacements in the `io` and `os` packages, which are not available in Go v1.14. [1]: https://go-review.googlesource.com/c/crypto/+/430797
Member
Author
|
The |
mandre
approved these changes
Nov 7, 2022
Contributor
mandre
left a comment
There was a problem hiding this comment.
LGTM. We should consider dropping go 1.14 support at some point so we can upgrade to a newer version of golang.org/x/crypto.
Contributor
|
Not sure why the |
Member
Author
Fixed here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the depedency to the last commit that is compatible with Go v1.14. The next commit replaces calls to
io/ioutilto its replacements in theioandospackages, which are not available in Go v1.14.