tests: Fix Go v1.14 "go vet"#2504
Merged
EmilienM merged 1 commit intogophercloud:masterfrom Nov 7, 2022
Merged
Conversation
c32699e to
60221e4
Compare
We use "go get" to install test dependencies in Go v1.14. As a side effect, `go.sum` was polluted and `golang.org/x/crypto` was bumped to a version that is incompatible with Go v1.14. With this change, installing test dependencies no longer changes the state of the checked-out repository.
f24c9b4 to
f3f4668
Compare
EmilienM
approved these changes
Nov 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use "go get" to install test dependencies in Go v1.14. As a side
effect,
go.sumwas polluted andgolang.org/x/cryptowas bumped to aversion that is incompatible with Go v1.14.
With this change, installing test dependencies no longer changes the
state of the checked-out repository.