Add Update to placement resourceproviders#2359
Merged
mandre merged 4 commits intogophercloud:masterfrom Mar 18, 2022
Merged
Conversation
b98ad69 to
466a6e0
Compare
Contributor
Author
|
hmmm theopenlab-ci is not in the check-list although i think its running |
Contributor
Author
|
recheck |
|
Build succeeded.
|
mandre
approved these changes
Feb 26, 2022
Contributor
mandre
left a comment
There was a problem hiding this comment.
Final patch and it all LGTM. Ready to merge the full patch stream IMO.
| // ToResourceProviderUpdateMap constructs a request body from UpdateOpts. | ||
| func (opts UpdateOpts) ToResourceProviderUpdateMap() (map[string]interface{}, error) { | ||
| b, err := gophercloud.BuildRequestBody(opts, "") | ||
| if err != nil { |
Contributor
There was a problem hiding this comment.
Nit: that shouldn't be necessary as b would always be nil when gophercloud.BuildRequestBody() returns an error.
The body of this function could simply be return gophercloud.BuildRequestBody(opts, "")
Add ParentProviderUUID to placement/v1/resourceproviders createOpts. Moreover restructure acceptance tests for consistency and for future additions. [Docs](https://docs.openstack.org/api-ref/placement/?expanded=create-resource-provider-detail) Relates to: gophercloud#526
466a6e0 to
5ed0361
Compare
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs
Relates to: #526
PR-train: requires #2358