Skip to content

Add Get to placement resourceproviders#2358

Merged
mandre merged 3 commits intogophercloud:masterfrom
nikParasyr:placement_rp_get
Mar 18, 2022
Merged

Add Get to placement resourceproviders#2358
mandre merged 3 commits intogophercloud:masterfrom
nikParasyr:placement_rp_get

Conversation

@nikParasyr
Copy link
Copy Markdown
Contributor

Docs
Relates to: #526

PR-train: requires #2357

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 23, 2022

Build failed.

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 23, 2022

Coverage Status

Coverage increased (+0.01%) to 79.905% when pulling 60fab0f on nikParasyr:placement_rp_get into beef396 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 23, 2022

Build succeeded.

Copy link
Copy Markdown
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

defer DeleteResourceProvider(t, client, resourceProvider.UUID)

resourceProvider, err = CreateResourceProviderWithParent(t, client, resourceProvider.UUID)
resourceProvider2, err := CreateResourceProviderWithParent(t, client, resourceProvider.UUID)
Copy link
Copy Markdown
Contributor

@mandre mandre Feb 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, this belongs to #2357 but not a big deal as we'll likely merge your PRs very close to each other.

@EmilienM
Copy link
Copy Markdown
Contributor

please rebase on master to run the new tests for placement API

@nikParasyr
Copy link
Copy Markdown
Contributor Author

please rebase on master to run the new tests for placement API

Dont have much time atm, but will try to do at the end of this week

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 18, 2022

Build succeeded.

@mandre mandre merged commit 97d5760 into gophercloud:master Mar 18, 2022
@nikParasyr nikParasyr deleted the placement_rp_get branch October 13, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants