[CI-v2] Add dns job with Github Action#2329
Merged
EmilienM merged 2 commits intogophercloud:masterfrom Jan 25, 2022
Merged
Conversation
Contributor
mandre
commented
Jan 25, 2022
- Deploy Designate with Devstack
- Run dns acceptance tests
- Logs failures if any
Contributor
Author
EmilienM
reviewed
Jan 25, 2022
| with: | ||
| branch: ${{ matrix.openstack_version }} | ||
| conf_overrides: | | ||
| enable_plugin designate https://opendev.org/openstack/designate ${{ matrix.openstack_version }} |
Contributor
There was a problem hiding this comment.
You'll need to add:
Q_ML2_PLUGIN_EXT_DRIVERS=dns
So you have the dns extension enabled in Neutron.
2cc3f1d to
e29cb3a
Compare
Contributor
Author
|
Ah! the Or I could change the regex to |
* Deploy Designate with Devstack * Run dns acceptance tests * Logs failures if any
It's not clear what is supposed to set the OS_DNS_ENVIRONMENT environment variable. Looks like it's not coming from devstack. Remove the RequireDNS check as we are now only running these acceptance tests against environment that have DNSaaS anyway.
Contributor
|
the PR looks good to me. I'll merge it once CI jobs are green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.