[CI-v2] Add loadbalancer job with Github Action#2328
[CI-v2] Add loadbalancer job with Github Action#2328mandre merged 1 commit intogophercloud:masterfrom EmilienM:civ2_loadbalancer
Conversation
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
* Deploy Octavia with Devstack * Run loadbalancer acceptance tests * Introduce IsReleasesAbove and IsReleasesBelow which return True if a release is above the current branch (or below). * Only test tls_versions in Victoria and beyond, not supported before. * Only add l7 parameters to QuotaUpdate in Victoria and beyond, not supported before. * Remove all the skips * Logs failures if any
| branch: ${{ matrix.openstack_version }} | ||
| conf_overrides: | | ||
| enable_plugin octavia https://opendev.org/openstack/octavia ${{ matrix.openstack_version }} | ||
| enable_plugin neutron https://opendev.org/openstack/neutron ${{ matrix.openstack_version }} |
There was a problem hiding this comment.
Isn't neutron part of core devstack? It feels a bit strange to have to enable it explicitly.
There was a problem hiding this comment.
we need the plugin from neutron because there are some functions called from devstack core, it's weird but it's like this (and it's only for some versions)... I think this is fine, upstream gate does the same.
There was a problem hiding this comment.
OK, might be related to https://bugs.launchpad.net/neutron/+bug/1955765
| // IsReleasesAbove will return true on releases above a certain | ||
| // one. The result is always true on master release. Releases are named such | ||
| // as 'stable/mitaka', master, etc. | ||
| func IsReleasesAbove(t *testing.T, release string) bool { |
There was a problem hiding this comment.
We should use these new functions in SkipReleasesAbove() and SkipReleasesBelow() to avoid duplicating the logic. Not necessarily for this patch.
There was a problem hiding this comment.
ok, got it. I'll prepare a patch soon.
| }).Extract() | ||
| } | ||
| // L7 parameters are only supported in microversion v2.19 introduced in victoria | ||
| if clients.IsReleasesAbove(t, "stable/ussuri") { |
There was a problem hiding this comment.
Unrelated to your patch but it looks like the implementation of L7 parameters is buggy, they should be pointers according to https://github.com/gophercloud/gophercloud/blob/master/docs/MICROVERSIONS.md#new-response-fields.
Same for tls version above.
There was a problem hiding this comment.
could you file an issue please?
|
Let's merge this. We can always refactor IsReleasesAbove() and friends in a follow-up patch, no urgency. |
release is above the current branch (or below).
supported before.