[CI-v2] Add loadbalancer job with Github Action

EmilienM · EmilienM · commit 44bf8e876415 · 2022-01-25T15:28:37.000-05:00
* Deploy Octavia with Devstack
* Run loadbalancer acceptance tests
* Introduce IsReleasesAbove and IsReleasesBelow which return True if a
  release is above the current branch (or below).
* Only test tls_versions in Victoria and beyond, not supported before.
* Only add l7 parameters to QuotaUpdate in Victoria and beyond, not
  supported before.
* Remove all the skips
* Logs failures if any
diff --git a/.github/workflows/functional-loadbalancer.yaml b/.github/workflows/functional-loadbalancer.yaml
@@ -0,0 +1,63 @@
+name: functional-loadbalancer
+on:
+  pull_request:
+    paths:
+      - '**loadbalancer**'
+  schedule:
+    - cron: '0 0 * * *'
+jobs:
+  functional-loadbalancer:
+    strategy:
+      fail-fast: false
+      matrix:
+        name: ["master"]
+        openstack_version: ["master"]
+        ubuntu_version: ["20.04"]
+        include:
+          - name: "xena"
+            openstack_version: "stable/xena"
+            ubuntu_version: "20.04"
+          - name: "wallaby"
+            openstack_version: "stable/wallaby"
+            ubuntu_version: "20.04"
+          - name: "victoria"
+            openstack_version: "stable/victoria"
+            ubuntu_version: "20.04"
+          - name: "ussuri"
+            openstack_version: "stable/ussuri"
+            ubuntu_version: "18.04"
+          - name: "train"
+            openstack_version: "stable/train"
+            ubuntu_version: "18.04"
+    runs-on: ubuntu-${{ matrix.ubuntu_version }}
+    name: Deploy OpenStack ${{ matrix.name }} with Octavia and run loadbalancer acceptance tests
+    steps:
+      - name: Checkout Gophercloud
+        uses: actions/checkout@v2
+      - name: Deploy devstack
+        uses: EmilienM/devstack-action@v0.6
+        with:
+          branch: ${{ matrix.openstack_version }}
+          conf_overrides: |
+            enable_plugin octavia https://opendev.org/openstack/octavia ${{ matrix.openstack_version }}
+            enable_plugin neutron https://opendev.org/openstack/neutron ${{ matrix.openstack_version }}
+          enabled_services: 'octavia,o-api,o-cw,o-hk,o-hm,o-da'
+      - name: Checkout go
+        uses: actions/setup-go@v2
+        with:
+          go-version: '^1.15'
+      - name: Run Gophercloud acceptance tests
+        run: ./script/acceptancetest
+        env:
+          DEVSTACK_PATH: ${{ github.workspace }}/devstack
+          ACCEPTANCE_TESTS_FILTER: "^.*loadbalancer.*$"
+          OS_BRANCH: ${{ matrix.openstack_version }}
+      - name: Generate logs on failure
+        run: ./script/collectlogs
+        if: failure()
+      - name: Upload logs artifacts on failure
+        if: failure()
+        uses: actions/upload-artifact@v2
+        with:
+          name: functional-loadbalancer-${{ matrix.name }}
+          path: /tmp/devstack-logs/*
diff --git a/acceptance/clients/conditions.go b/acceptance/clients/conditions.go
@@ -111,3 +111,29 @@ func SkipReleasesAbove(t *testing.T, release string) {
 		t.Skipf("this is not supported above %s, testing in %s", release, current_branch)
 	}
 }
+
+// IsReleasesAbove will return true on releases above a certain
+// one. The result is always true on master release. Releases are named such
+// as 'stable/mitaka', master, etc.
+func IsReleasesAbove(t *testing.T, release string) bool {
+	current_branch := os.Getenv("OS_BRANCH")
+
+	// Assume master is always too new
+	if current_branch == "master" || current_branch > release {
+		return true
+	}
+	t.Logf("Target release %s is below the current branch %s", release, current_branch)
+	return false
+}
+
+// IsReleasesBelow will return true on releases below a certain
+// one. Releases are named such as 'stable/mitaka', master, etc.
+func IsReleasesBelow(t *testing.T, release string) bool {
+	current_branch := os.Getenv("OS_BRANCH")
+
+	if current_branch != "master" && current_branch < release {
+		return true
+	}
+	t.Logf("Target release %s is above the current branch %s", release, current_branch)
+	return false
+}
diff --git a/acceptance/openstack/loadbalancer/v2/amphorae_test.go b/acceptance/openstack/loadbalancer/v2/amphorae_test.go
@@ -13,13 +13,6 @@ import (
 
 func TestAmphoraeList(t *testing.T) {
 	clients.RequireAdmin(t)
-	clients.SkipRelease(t, "stable/mitaka")
-	clients.SkipRelease(t, "stable/newton")
-	clients.SkipRelease(t, "stable/ocata")
-	clients.SkipRelease(t, "stable/pike")
-	clients.SkipRelease(t, "stable/queens")
-	clients.SkipRelease(t, "stable/rocky")
-
 	client, err := clients.NewLoadBalancerV2Client()
 	if err != nil {
 		t.Fatalf("Unable to create a loadbalancer client: %v", err)
diff --git a/acceptance/openstack/loadbalancer/v2/l7policies_test.go b/acceptance/openstack/loadbalancer/v2/l7policies_test.go
@@ -12,13 +12,6 @@ import (
 )
 
 func TestL7PoliciesList(t *testing.T) {
-	clients.SkipRelease(t, "stable/mitaka")
-	clients.SkipRelease(t, "stable/newton")
-	clients.SkipRelease(t, "stable/ocata")
-	clients.SkipRelease(t, "stable/pike")
-	clients.SkipRelease(t, "stable/queens")
-	clients.SkipRelease(t, "stable/rocky")
-
 	client, err := clients.NewLoadBalancerV2Client()
 	if err != nil {
 		t.Fatalf("Unable to create a loadbalancer client: %v", err)
diff --git a/acceptance/openstack/loadbalancer/v2/listeners_test.go b/acceptance/openstack/loadbalancer/v2/listeners_test.go
@@ -12,13 +12,6 @@ import (
 )
 
 func TestListenersList(t *testing.T) {
-	clients.SkipRelease(t, "stable/mitaka")
-	clients.SkipRelease(t, "stable/newton")
-	clients.SkipRelease(t, "stable/ocata")
-	clients.SkipRelease(t, "stable/pike")
-	clients.SkipRelease(t, "stable/queens")
-	clients.SkipRelease(t, "stable/rocky")
-
 	client, err := clients.NewLoadBalancerV2Client()
 	if err != nil {
 		t.Fatalf("Unable to create a loadbalancer client: %v", err)
diff --git a/acceptance/openstack/loadbalancer/v2/loadbalancer.go b/acceptance/openstack/loadbalancer/v2/loadbalancer.go
@@ -6,6 +6,7 @@ import (
 	"testing"
 
 	"github.com/gophercloud/gophercloud"
+	"github.com/gophercloud/gophercloud/acceptance/clients"
 	"github.com/gophercloud/gophercloud/acceptance/tools"
 	"github.com/gophercloud/gophercloud/openstack/loadbalancer/v2/l7policies"
 	"github.com/gophercloud/gophercloud/openstack/loadbalancer/v2/listeners"
@@ -57,6 +58,8 @@ func CreateListener(t *testing.T, client *gophercloud.ServiceClient, lb *loadbal
 // balancer on a random port with a random name. An error will be returned
 // if the listener could not be created.
 func CreateListenerHTTP(t *testing.T, client *gophercloud.ServiceClient, lb *loadbalancers.LoadBalancer) (*listeners.Listener, error) {
+	tlsVersions := []listeners.TLSVersion{}
+	tlsVersionsExp := []string(nil)
 	listenerName := tools.RandomString("TESTACCT-", 8)
 	listenerDescription := tools.RandomString("TESTACCT-DESC-", 8)
 	listenerPort := tools.RandomInt(1, 100)
@@ -67,8 +70,11 @@ func CreateListenerHTTP(t *testing.T, client *gophercloud.ServiceClient, lb *loa
 		"X-Forwarded-For": "true",
 	}
 
-	tlsVersions := []listeners.TLSVersion{"TLSv1.2", "TLSv1.3"}
-	tlsVersionsExp := []string{"TLSv1.2", "TLSv1.3"}
+	// tls_version is only supported in microversion v2.17 introduced in victoria
+	if clients.IsReleasesAbove(t, "stable/ussuri") {
+		tlsVersions = []listeners.TLSVersion{"TLSv1.2", "TLSv1.3"}
+		tlsVersionsExp = []string{"TLSv1.2", "TLSv1.3"}
+	}
 
 	createOpts := listeners.CreateOpts{
 		Name:           listenerName,
diff --git a/acceptance/openstack/loadbalancer/v2/loadbalancers_test.go b/acceptance/openstack/loadbalancer/v2/loadbalancers_test.go
@@ -18,13 +18,6 @@ import (
 )
 
 func TestLoadbalancersList(t *testing.T) {
-	clients.SkipRelease(t, "stable/mitaka")
-	clients.SkipRelease(t, "stable/newton")
-	clients.SkipRelease(t, "stable/ocata")
-	clients.SkipRelease(t, "stable/pike")
-	clients.SkipRelease(t, "stable/queens")
-	clients.SkipRelease(t, "stable/rocky")
-
 	client, err := clients.NewLoadBalancerV2Client()
 	th.AssertNoErr(t, err)
 
@@ -40,14 +33,6 @@ func TestLoadbalancersList(t *testing.T) {
 }
 
 func TestLoadbalancersListByTags(t *testing.T) {
-	clients.SkipRelease(t, "stable/mitaka")
-	clients.SkipRelease(t, "stable/newton")
-	clients.SkipRelease(t, "stable/ocata")
-	clients.SkipRelease(t, "stable/pike")
-	clients.SkipRelease(t, "stable/queens")
-	clients.SkipRelease(t, "stable/rocky")
-	t.Skip("Currently failing in OpenLab")
-
 	netClient, err := clients.NewNetworkV2Client()
 	th.AssertNoErr(t, err)
 
@@ -111,14 +96,6 @@ func TestLoadbalancersListByTags(t *testing.T) {
 }
 
 func TestLoadbalancerHTTPCRUD(t *testing.T) {
-	clients.SkipRelease(t, "stable/mitaka")
-	clients.SkipRelease(t, "stable/newton")
-	clients.SkipRelease(t, "stable/ocata")
-	clients.SkipRelease(t, "stable/pike")
-	clients.SkipRelease(t, "stable/queens")
-	clients.SkipRelease(t, "stable/rocky")
-	t.Skip("Currently failing in OpenLab")
-
 	netClient, err := clients.NewNetworkV2Client()
 	th.AssertNoErr(t, err)
 
@@ -168,14 +145,6 @@ func TestLoadbalancerHTTPCRUD(t *testing.T) {
 }
 
 func TestLoadbalancersCRUD(t *testing.T) {
-	clients.SkipRelease(t, "stable/mitaka")
-	clients.SkipRelease(t, "stable/newton")
-	clients.SkipRelease(t, "stable/ocata")
-	clients.SkipRelease(t, "stable/pike")
-	clients.SkipRelease(t, "stable/queens")
-	clients.SkipRelease(t, "stable/rocky")
-	t.Skip("Currently failing in OpenLab")
-
 	netClient, err := clients.NewNetworkV2Client()
 	th.AssertNoErr(t, err)
 
@@ -475,14 +444,6 @@ func TestLoadbalancersCRUD(t *testing.T) {
 }
 
 func TestLoadbalancersCascadeCRUD(t *testing.T) {
-	clients.SkipRelease(t, "stable/mitaka")
-	clients.SkipRelease(t, "stable/newton")
-	clients.SkipRelease(t, "stable/ocata")
-	clients.SkipRelease(t, "stable/pike")
-	clients.SkipRelease(t, "stable/queens")
-	clients.SkipRelease(t, "stable/rocky")
-	t.Skip("Currently failing in OpenLab")
-
 	netClient, err := clients.NewNetworkV2Client()
 	th.AssertNoErr(t, err)
 
@@ -597,14 +558,6 @@ func TestLoadbalancersCascadeCRUD(t *testing.T) {
 }
 
 func TestLoadbalancersFullyPopulatedCRUD(t *testing.T) {
-	clients.SkipRelease(t, "stable/mitaka")
-	clients.SkipRelease(t, "stable/newton")
-	clients.SkipRelease(t, "stable/ocata")
-	clients.SkipRelease(t, "stable/pike")
-	clients.SkipRelease(t, "stable/queens")
-	clients.SkipRelease(t, "stable/rocky")
-	t.Skip("Currently failing in OpenLab")
-
 	netClient, err := clients.NewNetworkV2Client()
 	th.AssertNoErr(t, err)
 
diff --git a/acceptance/openstack/loadbalancer/v2/monitors_test.go b/acceptance/openstack/loadbalancer/v2/monitors_test.go
@@ -12,13 +12,6 @@ import (
 )
 
 func TestMonitorsList(t *testing.T) {
-	clients.SkipRelease(t, "stable/mitaka")
-	clients.SkipRelease(t, "stable/newton")
-	clients.SkipRelease(t, "stable/ocata")
-	clients.SkipRelease(t, "stable/pike")
-	clients.SkipRelease(t, "stable/queens")
-	clients.SkipRelease(t, "stable/rocky")
-
 	client, err := clients.NewLoadBalancerV2Client()
 	if err != nil {
 		t.Fatalf("Unable to create a loadbalancer client: %v", err)
diff --git a/acceptance/openstack/loadbalancer/v2/pools_test.go b/acceptance/openstack/loadbalancer/v2/pools_test.go
@@ -12,13 +12,6 @@ import (
 )
 
 func TestPoolsList(t *testing.T) {
-	clients.SkipRelease(t, "stable/mitaka")
-	clients.SkipRelease(t, "stable/newton")
-	clients.SkipRelease(t, "stable/ocata")
-	clients.SkipRelease(t, "stable/pike")
-	clients.SkipRelease(t, "stable/queens")
-	clients.SkipRelease(t, "stable/rocky")
-
 	client, err := clients.NewLoadBalancerV2Client()
 	if err != nil {
 		t.Fatalf("Unable to create a loadbalancer client: %v", err)
diff --git a/acceptance/openstack/loadbalancer/v2/providers_test.go b/acceptance/openstack/loadbalancer/v2/providers_test.go
@@ -12,13 +12,6 @@ import (
 )
 
 func TestProvidersList(t *testing.T) {
-	clients.SkipRelease(t, "stable/mitaka")
-	clients.SkipRelease(t, "stable/newton")
-	clients.SkipRelease(t, "stable/ocata")
-	clients.SkipRelease(t, "stable/pike")
-	clients.SkipRelease(t, "stable/queens")
-	clients.SkipRelease(t, "stable/rocky")
-
 	client, err := clients.NewLoadBalancerV2Client()
 	if err != nil {
 		t.Fatalf("Unable to create a loadbalancer client: %v", err)
diff --git a/acceptance/openstack/loadbalancer/v2/quotas.go b/acceptance/openstack/loadbalancer/v2/quotas.go
diff --git a/acceptance/openstack/loadbalancer/v2/quotas_test.go b/acceptance/openstack/loadbalancer/v2/quotas_test.go
@@ -9,6 +9,7 @@ import (
 	"reflect"
 	"testing"
 
+	"github.com/gophercloud/gophercloud"
 	"github.com/gophercloud/gophercloud/acceptance/clients"
 	"github.com/gophercloud/gophercloud/acceptance/tools"
 	"github.com/gophercloud/gophercloud/openstack/loadbalancer/v2/quotas"
@@ -36,6 +37,19 @@ func TestQuotasUpdate(t *testing.T) {
 	originalQuotas, err := quotas.Get(client, os.Getenv("OS_PROJECT_NAME")).Extract()
 	th.AssertNoErr(t, err)
 
+	var quotaUpdateOpts = quotas.UpdateOpts{
+		Loadbalancer:  gophercloud.IntToPointer(25),
+		Listener:      gophercloud.IntToPointer(45),
+		Member:        gophercloud.IntToPointer(205),
+		Pool:          gophercloud.IntToPointer(25),
+		Healthmonitor: gophercloud.IntToPointer(5),
+	}
+	// L7 parameters are only supported in microversion v2.19 introduced in victoria
+	if clients.IsReleasesAbove(t, "stable/ussuri") {
+		quotaUpdateOpts.L7Policy = gophercloud.IntToPointer(55)
+		quotaUpdateOpts.L7Rule = gophercloud.IntToPointer(105)
+	}
+
 	newQuotas, err := quotas.Update(client, os.Getenv("OS_PROJECT_NAME"), quotaUpdateOpts).Extract()
 	th.AssertNoErr(t, err)
 
@@ -45,16 +59,21 @@ func TestQuotasUpdate(t *testing.T) {
 		log.Fatal("Original and New Loadbalancer Quotas are the same")
 	}
 
-	// Restore original quotas.
-	restoredQuotas, err := quotas.Update(client, os.Getenv("OS_PROJECT_NAME"), quotas.UpdateOpts{
+	var restoredQuotaUpdate = quotas.UpdateOpts{
 		Loadbalancer:  &originalQuotas.Loadbalancer,
 		Listener:      &originalQuotas.Listener,
 		Member:        &originalQuotas.Member,
 		Pool:          &originalQuotas.Pool,
 		Healthmonitor: &originalQuotas.Healthmonitor,
-		L7Policy:      &originalQuotas.L7Policy,
-		L7Rule:        &originalQuotas.L7Rule,
-	}).Extract()
+	}
+	// L7 parameters are only supported in microversion v2.19 introduced in victoria
+	if clients.IsReleasesAbove(t, "stable/ussuri") {
+		restoredQuotaUpdate.L7Policy = &originalQuotas.L7Policy
+		restoredQuotaUpdate.L7Rule = &originalQuotas.L7Rule
+	}
+
+	// Restore original quotas.
+	restoredQuotas, err := quotas.Update(client, os.Getenv("OS_PROJECT_NAME"), restoredQuotaUpdate).Extract()
 	th.AssertNoErr(t, err)
 
 	th.AssertDeepEquals(t, originalQuotas, restoredQuotas)
