Add ability to handle 502 and 504 errors#2245
Merged
mandre merged 3 commits intogophercloud:masterfrom May 21, 2022
pbasov:pbasov/master
Merged
Add ability to handle 502 and 504 errors#2245mandre merged 3 commits intogophercloud:masterfrom pbasov:pbasov/master
mandre merged 3 commits intogophercloud:masterfrom
pbasov:pbasov/master
Conversation
|
Build failed.
|
Contributor
Author
|
recheck |
|
Build failed.
|
Contributor
Author
|
recheck |
|
Build failed.
|
Member
|
recheck |
|
Build failed.
|
Contributor
|
The coverage decreased, could you please add tests in https://github.com/gophercloud/gophercloud/blob/master/testing/errors_test.go if that makes sense to you? Thanks for your contribution! |
Contributor
|
@pbasov hopefully this is fine for you, I pushed a patch to maintain unit testing coverage. Feel free to rework the patch that I sent. Thanks |
Contributor
|
oops sounds like coverage is still not happy. I'll take a look later unless you can check it as well. |
|
Build failed.
|
* Additional types to handle 502 Bad Gateway and 504 Gateway Timeout http errors
|
Build succeeded.
|
mandre
reviewed
May 21, 2022
Contributor
mandre
left a comment
There was a problem hiding this comment.
Just a small typo, otherwise looks like it's in good shape to merge.
mdelord
pushed a commit
to ovh/gophercloud
that referenced
this pull request
Oct 7, 2022
Additional types to handle 502 Bad Gateway and 504 Gateway Timeout http errors Co-authored-by: Pavel Basov <pbasov@mirantis.com> Co-authored-by: Emilien Macchi <emilien@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces additional types to handle 502 Bad Gateway and 504 Gateway Timeout http errors
For #2244
Related terraform-provider-openstack/terraform-provider-openstack#1303