Compute v2: Implement Hypervisor request options #2187
Merged
jtopjian merged 4 commits intogophercloud:masterfrom Jul 10, 2021
Merged
Compute v2: Implement Hypervisor request options #2187jtopjian merged 4 commits intogophercloud:masterfrom
jtopjian merged 4 commits intogophercloud:masterfrom
Conversation
Signed-off-by: Kien Nguyen <kiennt2609@gmail.com>
This commit changes hypervisors.Hypervisor.Servers from []*Server to *[]Server to better conform with microversioned result fields.
|
Build failed.
|
Contributor
Author
|
recheck |
|
Build succeeded.
|
Contributor
Author
|
@kayrus Do you mind reviewing this when you have time? |
kayrus
reviewed
Jul 1, 2021
Contributor
kayrus
left a comment
There was a problem hiding this comment.
I don't have a use case for this API call, I can only try to run acceptance tests.
The only thing that I have concerns on is an API version in docs.
| fmt.Printf("%+v\n", hypervisor) | ||
| } | ||
|
|
||
| Example of Retrieving Details of All Hypervisors with Compute API microversion greater than 2.33 |
Contributor
There was a problem hiding this comment.
Not clear which microversion end user needs to use. 2.33 or 2.53 (from the acceptance tests)
Contributor
Author
There was a problem hiding this comment.
It is confusing, yes. The newly added ListOpts includes options that are valid in either 2.33 or 2.53. The title of this example is supposed to denote that microversion 2.33+ is required.
|
Build succeeded.
|
This was referenced Jul 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #2132
Supersedes #2131