Skip to content

Compute: Handle Hypervisor request parameters#2131

Closed
ntk148v wants to merge 1 commit intogophercloud:masterfrom
ntk148v:hypervisor
Closed

Compute: Handle Hypervisor request parameters#2131
ntk148v wants to merge 1 commit intogophercloud:masterfrom
ntk148v:hypervisor

Conversation

@ntk148v
Copy link
Copy Markdown
Contributor

@ntk148v ntk148v commented Mar 18, 2021 •
edited
Loading

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

https://github.com/openstack/nova/blob/stable/victoria/nova/api/openstack/compute/hypervisors.py#L89

This field has become mandatory in microversion 2.75. If no servers is on hypervisor then empty list is returned.

Signed-off-by: Kien Nguyen kiennt2609@gmail.com

@ntk148v ntk148v changed the title Implement Hypervisor request options Compute: Handle Hypervisor request parameters Mar 18, 2021
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 18, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.0008%) to 79.847% when pulling 3b8d835 on ntk148v:hypervisor into 906fef2 on gophercloud:master.

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Mar 18, 2021

@ntk148v Thank you for submitting this. When you have a moment, please read over our contributor tutorial which outlines additional information needed for submitting a Pull Request. Please let me know if you have any questions.

@ntk148v
Copy link
Copy Markdown
Contributor Author

ntk148v commented Mar 22, 2021

@jtopjian I've updated the PR description.

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Mar 23, 2021

I've updated the PR description.

Thanks. Do you mind also opening an issue about this PR, too?

This field has become mandatory in microversion 2.75.

I apologize, but I don't understand what you mean by "mandatory"? The field is part of a result/response structure which the user has no control over. Additionally, if this field was added from a microversion, please see the microversions doc for instructions on how to handle it.

@ntk148v
Copy link
Copy Markdown
Contributor Author

ntk148v commented Mar 24, 2021

jtopjian
jtopjian requested changes Mar 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ntk148v Thank you for your patience with this. Please see the review comments and let me know if you have any questions.

@wangxiyuan
Copy link
Copy Markdown

wangxiyuan commented Mar 26, 2021

recheck

@wangxiyuan wangxiyuan mentioned this pull request Mar 26, 2021
Closed
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 26, 2021

Build failed.

@ntk148v
Implement Hypervisor request options
3b8d835 
Signed-off-by: Kien Nguyen <kiennt2609@gmail.com>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 26, 2021

Build failed.

@jtopjian jtopjian mentioned this pull request Jul 1, 2021
Merged
@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Jul 10, 2021

This has been merged as part of #2187

@jtopjian jtopjian closed this Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtopjian jtopjian jtopjian requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ntk148v @coveralls @jtopjian @wangxiyuan