Add tag and delete_on_termination for nova volumeattach#2177
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Jun 22, 2021
Merged
Add tag and delete_on_termination for nova volumeattach#2177jtopjian merged 1 commit intogophercloud:masterfrom
jtopjian merged 1 commit intogophercloud:masterfrom
Conversation
88878e5 to
68befeb
Compare
|
Build failed.
|
Contributor
|
recheck |
jtopjian
reviewed
Jun 17, 2021
| VolumeID: volume.ID, | ||
| VolumeID: volume.ID, | ||
| Tag: tag, | ||
| DeleteOnTermination: dot, |
Contributor
There was a problem hiding this comment.
The client's microversion will need to be set to 2.79 in acceptance/openstack/compute/v2/volumeattach_test.go.
|
Build failed.
|
|
Build succeeded.
|
Contributor
Author
|
@jtopjian its ready from my side |
Contributor
|
@nikParasyr Sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #2176
Add 2 new request and respond fields for volumeattach.
tag => added on 2.49 =>https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id45
delete_on_termination => added on 2.79 => https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#maximum-in-train
docs
schema schema
create get