Fix ErrUnexpectedResponseCode expected OK codes#2173
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Jun 1, 2021
Merged
Fix ErrUnexpectedResponseCode expected OK codes#2173jtopjian merged 1 commit intogophercloud:masterfrom
jtopjian merged 1 commit intogophercloud:masterfrom
Conversation
When receiving a response from OpenStack HTTP response code is checked against a list of OK codes. This list is either specific to the call being made or generic according to the HTTP verb. In the latter scenario, when a wrong code is received, an error is returned that does not contains the actual list of expected OK codes. It is misleading because you may think the list of accepted codes is not correctly defined. Actual: 'Expected HTTP response code [] when accessing [DELETE http://127.0.0.1:35195], but got 200 instead OK' Expected: 'Expected HTTP response code [202 204] when accessing [DELETE http://127.0.0.1:35195], but got 200 instead OK'
|
Build failed.
|
Contributor
|
@reenjii good catch 🙂 Are you still working on this or is this ready for review/merge? |
Contributor
Author
It is ready for review/merge, nothing else to add it's quite straightforward :) |
Contributor
|
@reenjii I figured - I just don't like to assume anything 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #2172