Neutron quota: int-as-string workaround#2126
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Mar 11, 2021
Merged
Conversation
kayrus
reviewed
Mar 11, 2021
1f34ea7 to
3325942
Compare
3325942 to
cb32ef9
Compare
In some conditions, Neutron will JSON-encode quota values as strings instead of integers. With this patch, the unmarshaling method is overridden to accept integers as strings. See https://bugs.launchpad.net/neutron/+bug/1918565 Fixes gophercloud#2125
cb32ef9 to
0297290
Compare
|
Build succeeded.
|
Contributor
|
great, I'll go with that until this is fixed in Neutron and backported. I suspect we'll carry this workaround for some time... |
Contributor
|
@pierreprinetti This looks good to me. To confirm: this is ready to be merged? |
Member
Author
As far as I can tell, the patch is ready. |
Contributor
|
@jtopjian LGTM, this is ready to go I think. Thanks Pierre for the quick workaround! |
Contributor
|
Thanks, all! I just like to make sure before I accidentally hit the merge button too early 🙂 |
Contributor
|
thanks @jtopjian for the ninja review! |
Member
Author
|
Thank you @jtopjian! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some conditions, Neutron will JSON-encode quota values as strings
instead of integers.
With this patch, the unmarshaling method is overridden to accept
integers as strings.
See https://bugs.launchpad.net/neutron/+bug/1918565
Fixes #2125