Skip to content

Glance: hide images from public list#2094

Merged
jtopjian merged 2 commits intogophercloud:masterfrom
fitbeard:add/glance_hidden_image
Jan 19, 2021
Merged

Glance: hide images from public list#2094
jtopjian merged 2 commits intogophercloud:masterfrom
fitbeard:add/glance_hidden_image

Conversation

@fitbeard
Copy link
Copy Markdown
Contributor

@fitbeard fitbeard commented Jan 9, 2021

For #2093

Link to OpenStack code, Commit with explanation: openstack/glance@a308c44

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 9, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 79.773% when pulling 00935bd on fitbeard:add/glance_hidden_image into 1875fb8 on gophercloud:master.

@fitbeard fitbeard force-pushed the add/glance_hidden_image branch 2 times, most recently from 7138eec to dbe77b8 Compare January 9, 2021 23:23
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 9, 2021

Build failed.

@fitbeard fitbeard force-pushed the add/glance_hidden_image branch 5 times, most recently from 3d65704 to 87ddf96 Compare January 10, 2021 08:52
@fitbeard fitbeard force-pushed the add/glance_hidden_image branch from 87ddf96 to b0bdc0c Compare January 10, 2021 09:08
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 10, 2021

Build succeeded.

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Jan 17, 2021

@fitbeard Thank you for working on this.

This PR adds support to create images that are hidden as well as adds the Hidden to the result struct. Did you also want to add Hidden to the ListOpts struct in this PR in order to list hidden images?

@fitbeard
Copy link
Copy Markdown
Contributor Author

fitbeard commented Jan 18, 2021

@jtopjian Both. Starting Rocky release every image after upload has os_hidden option with default value false . Listing is useful when you want to change image status. Frankly speaking I'm trying add this functionality to use later in OpenStack terraform provider.

@jtopjian
Copy link
Copy Markdown
Contributor

jtopjian commented Jan 18, 2021

@fitbeard Right, what I meant was that the PR you have submitted adds Hidden to CreateOpts but currently does not add the field to ListOps. Do you want to amend this PR to do that prior to review/merge?

@fitbeard
Copy link
Copy Markdown
Contributor Author

fitbeard commented Jan 18, 2021

@jtopjian you're right. Thank you. I forgot ListOpts:) Updated my pull request with a missing ListOpts piece.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 18, 2021

Build succeeded.

jtopjian
jtopjian approved these changes Jan 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 5c7edc8 into gophercloud:master Jan 19, 2021
@jtopjian jtopjian mentioned this pull request Jan 19, 2021
Closed
@fitbeard fitbeard mentioned this pull request Feb 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtopjian jtopjian jtopjian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fitbeard @coveralls @jtopjian