add AllProjects LitsOps on ServerGroups#2070
Conversation
|
Build failed.
|
|
@clementblaise This is a good start - thanks! Travis is reporting an error with the unit tests. You can reproduce this locally by doing: $ cd openstack/compute/v2/extensions/servergroups
$ go test -v ./testingThe files in the On the topic of the new parameter, instead of the API documentation, we need to see the actual Nova Python code that implements this feature. This is described here. This is a pretty hard step for new contributors, so I've dug up the references for you:
No further work is needed for these links - it just "proves" that a parameter called Please let me know if you have any questions or need any help with getting the unit tests to pass. |
|
@jtopjian Thanks for helping out on finding the references, indeed not trivial, I will know for the next time. I had forgotten the test I just pushed the modification. |
|
Build failed.
|
|
Build failed.
|
|
@jtopjian Acceptance test failed while setting up I am not sure what I am supposed to do, could you have a look ? |
|
recheck |
|
Build failed.
|
|
Build succeeded.
|
|
@clementblaise Is this ready for review/merge? |
|
@jtopjian Yes you can go ahead |
* github.com/gophercloud/gophercloud * github.com/gophercloud/utils * github.com/terraform-provider-openstack/terraform-provider-openstack Also adjust a call to servergroup.List to comply with the new function signature[1]. [1]: gophercloud/gophercloud#2070 Signed-off-by: Emilien Macchi <emilien@redhat.com>
Adjust call to servergroup.List to comply with the new function signature [1]. [1]: gophercloud/gophercloud#2070
Prior to starting a PR, please make sure you have read our
contributor tutorial.
Prior to a PR being reviewed, there needs to be a Github issue that the PR
addresses. Replace the brackets and text below with that issue number.
For #[2069]
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
[https://docs.openstack.org/api-ref/compute/?expanded=list-server-groups-detail#server-groups-os-server-groups]