Skip to content

Remove unused ServiceClient from servers.CreateOpts#2004

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
andreykaipov:remove-unused-code
Aug 14, 2020
Merged

Remove unused ServiceClient from servers.CreateOpts#2004
jtopjian merged 1 commit intogophercloud:masterfrom
andreykaipov:remove-unused-code

Conversation

@andreykaipov
Copy link
Copy Markdown
Contributor

Addresses #2003.

@andreykaipov
Copy link
Copy Markdown
Contributor Author

PR #1897 removed the need for this option.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.0008%) to 79.511% when pulling 5bcbeec on andreykaipov:remove-unused-code into 51f8fa1 on gophercloud:master.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Aug 12, 2020

Build succeeded.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian jtopjian merged commit 597f138 into gophercloud:master Aug 14, 2020
@andreykaipov andreykaipov deleted the remove-unused-code branch August 14, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants