Removing IDFromName Functions#1897
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Mar 16, 2020
Merged
Conversation
These functions will be moved to https://github.com/gophercloud/utils.
1 similar comment
|
Build succeeded.
|
| // ImageName [optional; required if ImageRef is not provided] is the name of | ||
| // the image that contains the server's OS and initial state. | ||
| // Also optional if using the boot-from-volume extension. | ||
| ImageName string `json:"-"` |
Contributor
There was a problem hiding this comment.
Was removing the ImageName and FlavorName options intended? It was a nice convenience to be able to pass the service client and not have to worry about calling IDFromName(...) ourselves. If so, it might be worthwhile to remove the ServiceClient as an option from the CreateOpts here and possibly other packages as it serves no purpose anymore.
Contributor
Author
There was a problem hiding this comment.
Good catch. Yes, it was intended though I do agree that it removes some well-received convenience.
This was referenced Aug 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1896