Support merge_labels when creating Magnum cluster#1985
Merged
jtopjian merged 1 commit intogophercloud:masterfrom Jun 25, 2020
Merged
Support merge_labels when creating Magnum cluster#1985jtopjian merged 1 commit intogophercloud:masterfrom
merge_labels when creating Magnum cluster#1985jtopjian merged 1 commit intogophercloud:masterfrom
Conversation
|
Build failed.
|
Contributor
|
@openstacker The OpenLab failure is ignorable - it was a temporary failure. This looks good to me - is this ready for review/merge? |
Contributor
Author
Yep, it's ready for review. I tested locally. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1984
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
The feature was introduced in OpenStack Magnum by https://review.opendev.org/#/c/720221/