Skip to content

Support system scope in v3 auth#1908

Merged
jtopjian merged 1 commit intogophercloud:masterfrom
zhsj:system-scope
Mar 28, 2020
Merged

Support system scope in v3 auth#1908
jtopjian merged 1 commit intogophercloud:masterfrom
zhsj:system-scope

Conversation

@zhsj
Copy link
Copy Markdown
Contributor

@zhsj zhsj commented Mar 27, 2020

@zhsj zhsj force-pushed the system-scope branch 2 times, most recently from 940bf5a to 2c5dc3e Compare March 27, 2020 03:42
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 27, 2020

Coverage Status

Coverage decreased (-0.02%) to 78.75% when pulling 468fea8 on zhsj:system-scope into dd42124 on gophercloud:master.

@jtopjian
Copy link
Copy Markdown
Contributor

@zhsj Thank you for submitting this. For future reference, we don't use the API docs as the only reference - we also need the actual OpenStack service code that implements the API feature. I've modified this PR description for you to include it.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Mar 27, 2020

Build failed.

Copy link
Copy Markdown
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@jtopjian
Copy link
Copy Markdown
Contributor

The OpenLab error is ignorable.

@jtopjian jtopjian merged commit aac4f27 into gophercloud:master Mar 28, 2020
@zhsj zhsj deleted the system-scope branch March 28, 2020 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants